1374146 - Crash in java.util.NoSuchElementException: Death link does not exist at android.os.BinderProxy.unlinkToDeath(Native Method)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gerry Chang [:gchang]]

This bug was filed from the Socorro interface and is 
report bp-cbdfa27a-5ee1-48ad-a5e9-025960170619.
=============================================================

This is #29 topcrash of fennec in FF54 for android and there is a spike when we enable 99% update rate.

Hi :snorp, 
Can you help find someone for this issue?

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Remote codec stuff -> jolin

Comment 2

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1374146 - handle already released death recipient exception.

Review commit: https://reviewboard.mozilla.org/r/154382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154382/

Comment 3

[Eugen Sawin [:esawin]]

Comment on attachment 8883477 [details]
Bug 1374146 - handle already released death recipient exception.

https://reviewboard.mozilla.org/r/154382/#review159554

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a39adfb94ae
handle already released death recipient exception. r=esawin

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a39adfb94ae

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Too late for 54 at this point, but could we please nominate this for Beta approval still?

Comment 7

[John Lin [:jhlin][:jolin]]

Comment on attachment 8883477 [details]
Bug 1374146 - handle already released death recipient exception.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1324530
[User impact if declined]: browser crash
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: it protects browser from crashing when service disconnection callback executes after remote manager is released, which could happen if remote process dies at the same time when releasing codec.
[String changes made/needed]: none

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8883477 [details]
Bug 1374146 - handle already released death recipient exception.

exception handling to fix a fennec crash, beta55+

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/15a56cd80f81