1374148 - Crash in nvwgf2um.dll | CDecodeContext::BeginFrame

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Gerry Chang [:gchang]]

This bug was filed from the Socorro interface and is 
report bp-55e3cf62-192c-41d6-9dad-5d4340170619.
=============================================================
Frame 	Module 	Signature 	Source
Ø 0 	nvwgf2um.dll 	nvwgf2um.dll@0xb53a7b 	
Ø 1 	nvwgf2um.dll 	nvwgf2um.dll@0xb5544a 	
Ø 2 	nvwgf2um.dll 	nvwgf2um.dll@0xb87118 	
Ø 3 	nvwgf2um.dll 	nvwgf2um.dll@0xba8512 	
Ø 4 	nvwgf2um.dll 	nvwgf2um.dll@0xbb7898 	
Ø 5 	nvwgf2um.dll 	nvwgf2um.dll@0xb578e7 	
Ø 6 	nvwgf2um.dll 	nvwgf2um.dll@0xb5d623 	
Ø 7 	nvwgf2um.dll 	nvwgf2um.dll@0xb46ee3 	
Ø 8 	nvwgf2um.dll 	nvwgf2um.dll@0x1b6a3d 	
9 	d3d11.dll 	CDecodeContext::BeginFrame(ID3D11VideoDecoderOutputView*, void const*, unsigned int) 	
10 	d3d11.dll 	CContext::DecoderBeginFrame(ID3D11VideoDecoder*, ID3D11VideoDecoderOutputView*, unsigned int, void const*) 	
Ø 11 	msmpeg2vdec.dll 	msmpeg2vdec.dll@0x77cab 	
Ø 12 	msmpeg2vdec.dll 	msmpeg2vdec.dll@0x7461f 	
Ø 13 	msmpeg2vdec.dll 	msmpeg2vdec.dll@0x75e50 	
Ø 14 	msmpeg2vdec.dll 	msmpeg2vdec.dll@0x747e6 	
Ø 15 	msmpeg2vdec.dll 	msmpeg2vdec.dll@0x78ebe 	
Ø 16 	msmpeg2vdec.dll 	msmpeg2vdec.dll@0x78c29 	
17 	kernel32.dll 	BaseThreadInitThunk 	
18 	ntdll.dll 	__RtlUserThreadStart 	
19 	ntdll.dll 	_RtlUserThreadStart

This is #7 topcrash of Firefox 54. 

Hi Blake,
Can you help shed some light here?

Comment 1

[Marcia Knous [:marcia]]

Many of the comments mention crashing while using Facebook:

Crashed again while veiwing facebook. Why has firefox become so unstable? 
I always have issues with Facebook. Firefox usually freezes and I have to use Task Manager to kill it. 
seems that facebook as some memory leaks that causes crashes easily 
just looking on the facebook home wall and firefox crashed. no videos were running. 
One Tab open, Facebook. Crashed while scrolling.

Comment 2

[Blake Wu [:bwu][:blakewu]]

Gerald, 
Can you check if we could blacklist it?

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

There were already a few versions for which D3D11 was blacklisted, and these don't appear in crash reports (meaning the blacklisting worked for them).
So I will add these new versions found from all the reports:
22.21.13.8253, 22.21.13.8233, 22.21.13.8205, 22.21.13.8189, 22.21.13.8178, 22.21.13.8165, 21.21.13.7892, 21.21.13.7878, 21.21.13.7866, 21.21.13.7849, 21.21.13.7654, 21.21.13.7653, 21.21.13.7633, 21.21.13.7619, 21.21.13.7563, 21.21.13.7306, 21.21.13.7290, 21.21.13.7270, 21.21.13.7254, 21.21.13.6939, 21.21.13.6926, 21.21.13.6909, 21.21.13.4201, 21.21.13.4200, 10.18.13.6881, 10.18.13.6839, 10.18.13.6472, 10.18.13.6143, 10.18.13.5946, 10.18.13.5923, 10.18.13.5921, 10.18.13.5445, 10.18.13.5362, 9.18.13.4788, 9.18.13.4752, 9.18.13.4725, 9.18.13.4709, 9.18.13.4192, 9.18.13.4144, 9.18.13.4052, 9.18.13.3788, 9.18.13.3523, 9.18.13.3235, 9.18.13.2723, 9.18.13.2702, 9.18.13.1422, 9.18.13.1407, 9.18.13.1106, 9.18.13.546

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1374148 - Block D3D11 on more crashy nvwgf2um.dll versions -

Review commit: https://reviewboard.mozilla.org/r/150732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150732/

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8879407 [details]
Bug 1374148 - Block D3D11 on more crashy nvwgf2um.dll versions -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150732/diff/1-2/

Comment 6

[Blake Wu [:bwu][:blakewu]]

Comment on attachment 8879407 [details]
Bug 1374148 - Block D3D11 on more crashy nvwgf2um.dll versions -

https://reviewboard.mozilla.org/r/150732/#review155452

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58e1d5cd63c0
Block D3D11 on more crashy nvwgf2um.dll versions - r=bwu

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8879407 [details]
Bug 1374148 - Block D3D11 on more crashy nvwgf2um.dll versions -

Approval Request Comment
[Feature/Bug causing the regression]: D3D11 decoding with some Nvidia drivers
[User impact if declined]: Crashes during media playback (currently 8th top crasher on 54)
[Is this code covered by automated tests?]: Not possible as it's a pref change covering more driver versions, which we don't have on our try machines
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Probably not possible, as it requires specific cards&drivers, and is still rare/intermittent enough and therefore hard to reproduce
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only adding more versions of an already-blacklisted driver, in the worst case we are making video playback more CPU-intensive for a class of users who wouldn't have experienced crashes -- Note that we are considering removing D3D blacklists for e10s, so most users should be unblocked soon (see bug 1372070)
[String changes made/needed]: None

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/58e1d5cd63c0

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8879407 [details]
Bug 1374148 - Block D3D11 on more crashy nvwgf2um.dll versions -

d3d11 blocklist additions, beta55+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5f815e9ef25b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Should we nominate this for mozilla-release to get it on the radar for possible Fx54 dot release consideration? Also, how about ESR52?

Comment 13

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1374148-release.patch

(Trivial rebase from the original patch, carrying r+ from comment 6)

Approval Request Comment
[Feature/Bug causing the regression]: Hardware video decoding
[User impact if declined]: ~2000 crashes per week on release
[Is this code covered by automated tests?]: No (it's only a block-list update)
[Has the fix been verified in Nightly?]: No (it's only a block-list update, and there are too few crashes on Nightly&beta to see a change)
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's only a block-list update
[String changes made/needed]: None

Comment 14

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1374148-esr52.patch

(Trivial rebase from the original patch, carrying r+ from comment 6)

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Just an updated block-list to reduce crashes
User impact if declined: ~45 crashes per week
Fix Landed on Version: 56, 55b
Risk to taking this patch (and alternatives if risky): No risks (it's only a block-list update)
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8882222 [details] [diff] [review]
1374148-esr52.patch

Block D3D11 to avoid crashes. Let's uplift to ESR52.3.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/3f84d97b2d55

Comment 17

[Gerry Chang [:gchang]]

Comment on attachment 8882218 [details] [diff] [review]
1374148-release.patch

We are only one week from 55 RC build. Release54-.