Closed Bug 1374289 Opened 2 years ago Closed 2 years ago

clicktoactivate rollout addon: branches "user-changed-from-user-changed-from-control" and " user-changed-from-user-changed-from-test"

Categories

(Core :: Plug-ins, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox54 --- unaffected
firefox55 + fixed
firefox56 --- fixed

People

(Reporter: benjamin, Assigned: Felipe)

References

Details

Attachments

(1 file)

The click to activate rollout addon is showing branches of the following form:
	user-changed-from-user-changed-from-control
	user-changed-from-user-changed-from-test

Once a user hits the "user-changed-from" state, we should leave them in that state, probably by removing the pref listener.
[Tracking Requested - why for this release]: this could cause problems with exploding values if users change their mind much
Priority: -- → P2
Comment on attachment 8880084 [details]
Bug 1374289 - Click-to-play rollout: stop watching for pref changes after the first change has been noticed.

https://reviewboard.mozilla.org/r/151432/#review156388
Attachment #8880084 - Flags: review?(benjamin) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/169fc55f0e8a
Click-to-play rollout: stop watching for pref changes after the first change has been noticed. r=bsmedberg
https://hg.mozilla.org/mozilla-central/rev/169fc55f0e8a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment on attachment 8880084 [details]
Bug 1374289 - Click-to-play rollout: stop watching for pref changes after the first change has been noticed.

Approval Request Comment
[Feature/Bug causing the regression]: rollout addon
[User impact if declined]: probably no user impact, but analysis will much more difficult
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: manual testing of the affected situation
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:  bug 1372237 is related but they can land independently
[Is the change risky?]: no, it's technically tightly scoped
[String changes made/needed]: none
Attachment #8880084 - Flags: approval-mozilla-beta?
Comment on attachment 8880084 [details]
Bug 1374289 - Click-to-play rollout: stop watching for pref changes after the first change has been noticed.

ctp rollout fix, beta55+

Should be in 55.0b5
Attachment #8880084 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.