1374289 - clicktoactivate rollout addon: branches "user-changed-from-user-changed-from-control" and " user-changed-from-user-changed-from-test"

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Benjamin Smedberg]

The click to activate rollout addon is showing branches of the following form:
	user-changed-from-user-changed-from-control
	user-changed-from-user-changed-from-test

Once a user hits the "user-changed-from" state, we should leave them in that state, probably by removing the pref listener.

Comment 1

[Benjamin Smedberg]

[Tracking Requested - why for this release]: this could cause problems with exploding values if users change their mind much

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1374289 - Click-to-play rollout: stop watching for pref changes after the first change has been noticed.

Review commit: https://reviewboard.mozilla.org/r/151432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151432/

Comment 3

[Benjamin Smedberg]

Comment on attachment 8880084 [details]
Bug 1374289 - Click-to-play rollout: stop watching for pref changes after the first change has been noticed.

https://reviewboard.mozilla.org/r/151432/#review156388

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/169fc55f0e8a
Click-to-play rollout: stop watching for pref changes after the first change has been noticed. r=bsmedberg

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/169fc55f0e8a

Comment 6

[Benjamin Smedberg]

Comment on attachment 8880084 [details]
Bug 1374289 - Click-to-play rollout: stop watching for pref changes after the first change has been noticed.

Approval Request Comment
[Feature/Bug causing the regression]: rollout addon
[User impact if declined]: probably no user impact, but analysis will much more difficult
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: manual testing of the affected situation
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:  bug 1372237 is related but they can land independently
[Is the change risky?]: no, it's technically tightly scoped
[String changes made/needed]: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8880084 [details]
Bug 1374289 - Click-to-play rollout: stop watching for pref changes after the first change has been noticed.

ctp rollout fix, beta55+

Should be in 55.0b5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3a9784ae18a1