1374333 - Ensure all Talos Pageloader tests can return Gecko Profiles for all processes when run with --geckoProfiler

Status: RESOLVED FIXED

(Testing :: Talos, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

At least for tsvgx, we only return samples for the content process that the test runs in, which isn't always useful.

At the very least, we want the main thread in the parent process and compositor thread as well.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I need this for bug 1357093.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Make Pageloader use TalosParentProfiler.

Review commit: https://reviewboard.mozilla.org/r/151906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151906/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler for profiling in tsvgx tests.

Review commit: https://reviewboard.mozilla.org/r/151908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151908/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in tscroll tests.

Review commit: https://reviewboard.mozilla.org/r/151910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151910/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded.

Review commit: https://reviewboard.mozilla.org/r/151912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151912/

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Increase number of samples for tps

Review commit: https://reviewboard.mozilla.org/r/151914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151914/

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: WIP - fix kraken

Review commit: https://reviewboard.mozilla.org/r/151916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151916/

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Allow TalosContentProfiler.js to pause and resume without initializing if the profiler should already be running in the parent.

Review commit: https://reviewboard.mozilla.org/r/155358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155358/

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Allow TalosContentProfiler.js to be loaded as both a frame script and as a normal DOM script.

Review commit: https://reviewboard.mozilla.org/r/155360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155360/

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880584 [details]
Bug 1374333 - TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151912/diff/1-2/

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880581 [details]
Bug 1374333 - Make Pageloader use TalosParentProfiler.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151906/diff/1-2/

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880582 [details]
Bug 1374333 - Use TalosContentProfiler for profiling in tsvgx tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151908/diff/1-2/

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880583 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tscroll tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151910/diff/1-2/

Comment 14

[Mike Conley (:mconley) (:⚙️)]

There's still more work to do here, but I think these patches in my stack are pretty stable and can be reviewed now.

Comment 15

[Robert Wood [:rwood]]

Comment on attachment 8884447 [details]
Bug 1374333 - Allow TalosContentProfiler.js to pause and resume without initializing if the profiler should already be running in the parent.

https://reviewboard.mozilla.org/r/155358/#review160752

Comment 16

[Robert Wood [:rwood]]

Comment on attachment 8884448 [details]
Bug 1374333 - Allow TalosContentProfiler.js to be loaded as both a frame script and as a normal DOM script.

https://reviewboard.mozilla.org/r/155360/#review160774

Comment 17

[Robert Wood [:rwood]]

Comment on attachment 8880584 [details]
Bug 1374333 - TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded.

https://reviewboard.mozilla.org/r/151912/#review160780

Comment 18

[Robert Wood [:rwood]]

Comment on attachment 8880581 [details]
Bug 1374333 - Make Pageloader use TalosParentProfiler.

https://reviewboard.mozilla.org/r/151906/#review160786

Looks great

Comment 19

[Robert Wood [:rwood]]

Comment on attachment 8880582 [details]
Bug 1374333 - Use TalosContentProfiler for profiling in tsvgx tests.

https://reviewboard.mozilla.org/r/151908/#review160846

LGTM

Comment 20

[Robert Wood [:rwood]]

Comment on attachment 8880583 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tscroll tests.

https://reviewboard.mozilla.org/r/151910/#review160862

Looks great!

Comment 21

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Make pageloader start and capture profiles at better times.

Before, we were doing capture after moving from page to page, but keeping the cycles all
within the same profile.

This change causes us to capture separate profiles for each page load, regardless of whether
or not they're just another cycle for a particular page.

This is particularly useful for tests like tps which use the pageloader to load a single test
URL over multiple cycles.

Review commit: https://reviewboard.mozilla.org/r/157180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157180/

Comment 22

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosParentProfiler to fix profiling in damp tests.

Review commit: https://reviewboard.mozilla.org/r/157182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157182/

Comment 23

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in glterrain tests.

Review commit: https://reviewboard.mozilla.org/r/157184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157184/

Comment 24

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in glvideo tests.

Review commit: https://reviewboard.mozilla.org/r/157186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157186/

Comment 25

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in tpaint tests.

Review commit: https://reviewboard.mozilla.org/r/157188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157188/

Comment 26

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in tcanvasmark tests.

Review commit: https://reviewboard.mozilla.org/r/157190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157190/

Comment 27

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in basic_compositor_video tests.

Review commit: https://reviewboard.mozilla.org/r/157192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157192/

Comment 28

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in a11yr tests.

Review commit: https://reviewboard.mozilla.org/r/157194/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157194/

Comment 29

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in bloom_basic tests.

Review commit: https://reviewboard.mozilla.org/r/157196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157196/

Comment 30

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Ensure we get profiles for all content processes for tps by waiting until the profiles are gathered before closing the tabs.

There seems to be a race where the ProfilerParent::SendGatherProfile Promise can fail
if the shutdown message has been sent by ContentParent. This means that exit profiles
are on their way, but the gatherer is going to hear about the rejected Promises first
and decrement the mPendingProfiles counter (with empty profiles) before the exit
profiles can arrive.

This is a workaround. Bug 1380785 has been filed for the ProfilerParent race.

Review commit: https://reviewboard.mozilla.org/r/157198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157198/

Comment 31

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in kraken tests.

Review commit: https://reviewboard.mozilla.org/r/157200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157200/

Comment 32

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Use TalosContentProfiler to fix profiling in dromaeo tests.

Review commit: https://reviewboard.mozilla.org/r/157202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157202/

Comment 33

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1374333 - Bump and sign new versions of TalosPowers, Pageloader, damp and tps.

Review commit: https://reviewboard.mozilla.org/r/157204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157204/

Comment 34

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880584 [details]
Bug 1374333 - TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151912/diff/2-3/

Comment 35

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880581 [details]
Bug 1374333 - Make Pageloader use TalosParentProfiler.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151906/diff/2-3/

Comment 36

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8884447 [details]
Bug 1374333 - Allow TalosContentProfiler.js to pause and resume without initializing if the profiler should already be running in the parent.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155358/diff/1-2/

Comment 37

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8884448 [details]
Bug 1374333 - Allow TalosContentProfiler.js to be loaded as both a frame script and as a normal DOM script.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155360/diff/1-2/

Comment 38

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880582 [details]
Bug 1374333 - Use TalosContentProfiler for profiling in tsvgx tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151908/diff/2-3/

Comment 39

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880583 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tscroll tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151910/diff/2-3/

Comment 40

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880584 [details]
Bug 1374333 - TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151912/diff/3-4/

Comment 41

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880581 [details]
Bug 1374333 - Make Pageloader use TalosParentProfiler.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151906/diff/3-4/

Comment 42

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8884447 [details]
Bug 1374333 - Allow TalosContentProfiler.js to pause and resume without initializing if the profiler should already be running in the parent.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155358/diff/2-3/

Comment 43

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8884448 [details]
Bug 1374333 - Allow TalosContentProfiler.js to be loaded as both a frame script and as a normal DOM script.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155360/diff/2-3/

Comment 44

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880582 [details]
Bug 1374333 - Use TalosContentProfiler for profiling in tsvgx tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151908/diff/3-4/

Comment 45

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880583 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tscroll tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151910/diff/3-4/

Comment 46

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886400 [details]
Bug 1374333 - Make pageloader start and capture profiles at better times.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157180/diff/1-2/

Comment 47

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886401 [details]
Bug 1374333 - Use TalosParentProfiler to fix profiling in damp tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157182/diff/1-2/

Comment 48

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886402 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in glterrain tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157184/diff/1-2/

Comment 49

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886403 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in glvideo tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157186/diff/1-2/

Comment 50

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886404 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tpaint tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157188/diff/1-2/

Comment 51

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886405 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tcanvasmark tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157190/diff/1-2/

Comment 52

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886406 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in basic_compositor_video tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157192/diff/1-2/

Comment 53

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886407 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in a11yr tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157194/diff/1-2/

Comment 54

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886408 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in bloom_basic tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157196/diff/1-2/

Comment 55

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886409 [details]
Bug 1374333 - Ensure we get profiles for all content processes for tps by waiting until the profiles are gathered before closing the tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157198/diff/1-2/

Comment 56

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886410 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in kraken tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157200/diff/1-2/

Comment 57

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886411 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in dromaeo tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157202/diff/1-2/

Comment 58

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886412 [details]
Bug 1374333 - Bump and sign new versions of TalosPowers, Pageloader, damp and tps.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157204/diff/1-2/

Comment 59

[Mike Conley (:mconley) (:⚙️)]

That last push was just a rebase.

Comment 60

[Robert Wood [:rwood]]

Comment on attachment 8886400 [details]
Bug 1374333 - Make pageloader start and capture profiles at better times.

https://reviewboard.mozilla.org/r/157180/#review163554

Comment 61

[Robert Wood [:rwood]]

Comment on attachment 8886401 [details]
Bug 1374333 - Use TalosParentProfiler to fix profiling in damp tests.

https://reviewboard.mozilla.org/r/157182/#review163564

Comment 62

[Robert Wood [:rwood]]

Comment on attachment 8886402 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in glterrain tests.

https://reviewboard.mozilla.org/r/157184/#review163566

Comment 63

[Robert Wood [:rwood]]

Comment on attachment 8886403 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in glvideo tests.

https://reviewboard.mozilla.org/r/157186/#review163570

Comment 64

[Robert Wood [:rwood]]

Comment on attachment 8886404 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tpaint tests.

https://reviewboard.mozilla.org/r/157188/#review163572

Comment 65

[Robert Wood [:rwood]]

Comment on attachment 8886405 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tcanvasmark tests.

https://reviewboard.mozilla.org/r/157190/#review163574

Comment 66

[Robert Wood [:rwood]]

Comment on attachment 8886406 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in basic_compositor_video tests.

https://reviewboard.mozilla.org/r/157192/#review163578

Comment 67

[Robert Wood [:rwood]]

Comment on attachment 8886407 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in a11yr tests.

https://reviewboard.mozilla.org/r/157194/#review163580

Comment 68

[Robert Wood [:rwood]]

Comment on attachment 8886408 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in bloom_basic tests.

https://reviewboard.mozilla.org/r/157196/#review163582

Comment 69

[Robert Wood [:rwood]]

Comment on attachment 8886409 [details]
Bug 1374333 - Ensure we get profiles for all content processes for tps by waiting until the profiles are gathered before closing the tabs.

https://reviewboard.mozilla.org/r/157198/#review163600

Comment 70

[Robert Wood [:rwood]]

Comment on attachment 8886410 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in kraken tests.

https://reviewboard.mozilla.org/r/157200/#review163608

Comment 71

[Robert Wood [:rwood]]

Comment on attachment 8886411 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in dromaeo tests.

https://reviewboard.mozilla.org/r/157202/#review163610

::: testing/talos/talos/tests/dromaeo/webrunner.js:128
(Diff revision 2)
> -				}
> +					}
>  
> -				if ( pos < numTests ) {
> +					TalosContentProfiler.pause(name, true).then(() => {
> +					  // For making Median and Variance
> +					  if (runStyle === "runs/s") {
> +					  	times.push((runs * 1000) / (cur - start));

nit whitespace

::: testing/talos/talos/tests/dromaeo/webrunner.js:130
(Diff revision 2)
> -				if ( pos < numTests ) {
> +					TalosContentProfiler.pause(name, true).then(() => {
> +					  // For making Median and Variance
> +					  if (runStyle === "runs/s") {
> +					  	times.push((runs * 1000) / (cur - start));
> +					  } else {
> +					  	times.push(cur - start);

nit whitespace

::: testing/talos/talos/tests/dromaeo/webrunner.js:153
(Diff revision 2)
> -								
> +
>  				    	logTest(data);
> -			
> +
>  				    	dequeue();
> -				}
> +					}
> +          });

I'm a bit confused about the alignment here but probably just how it's displayed in mozreview perhaps

Comment 72

[Robert Wood [:rwood]]

Comment on attachment 8886412 [details]
Bug 1374333 - Bump and sign new versions of TalosPowers, Pageloader, damp and tps.

https://reviewboard.mozilla.org/r/157204/#review163628

Comment 73

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886411 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in dromaeo tests.

https://reviewboard.mozilla.org/r/157202/#review163610

> I'm a bit confused about the alignment here but probably just how it's displayed in mozreview perhaps

Ah - this file used tabs for spacing, and my editor was hiding that for some reason. Thanks! Will fix before landing.

Comment 74

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880584 [details]
Bug 1374333 - TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151912/diff/4-5/

Comment 75

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880581 [details]
Bug 1374333 - Make Pageloader use TalosParentProfiler.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151906/diff/4-5/

Comment 76

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8884447 [details]
Bug 1374333 - Allow TalosContentProfiler.js to pause and resume without initializing if the profiler should already be running in the parent.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155358/diff/3-4/

Comment 77

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8884448 [details]
Bug 1374333 - Allow TalosContentProfiler.js to be loaded as both a frame script and as a normal DOM script.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155360/diff/3-4/

Comment 78

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880582 [details]
Bug 1374333 - Use TalosContentProfiler for profiling in tsvgx tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151908/diff/4-5/

Comment 79

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880583 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tscroll tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151910/diff/4-5/

Comment 80

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886400 [details]
Bug 1374333 - Make pageloader start and capture profiles at better times.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157180/diff/2-3/

Comment 81

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886401 [details]
Bug 1374333 - Use TalosParentProfiler to fix profiling in damp tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157182/diff/2-3/

Comment 82

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886402 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in glterrain tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157184/diff/2-3/

Comment 83

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886403 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in glvideo tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157186/diff/2-3/

Comment 84

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886404 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tpaint tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157188/diff/2-3/

Comment 85

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886405 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tcanvasmark tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157190/diff/2-3/

Comment 86

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886406 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in basic_compositor_video tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157192/diff/2-3/

Comment 87

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886407 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in a11yr tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157194/diff/2-3/

Comment 88

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886408 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in bloom_basic tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157196/diff/2-3/

Comment 89

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886409 [details]
Bug 1374333 - Ensure we get profiles for all content processes for tps by waiting until the profiles are gathered before closing the tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157198/diff/2-3/

Comment 90

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886410 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in kraken tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157200/diff/2-3/

Comment 91

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886411 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in dromaeo tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157202/diff/2-3/

Comment 92

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886412 [details]
Bug 1374333 - Bump and sign new versions of TalosPowers, Pageloader, damp and tps.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157204/diff/2-3/

Comment 93

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98897becd786
TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded. r=rwood
https://hg.mozilla.org/integration/autoland/rev/6f6b8285c422
Make Pageloader use TalosParentProfiler. r=rwood
https://hg.mozilla.org/integration/autoland/rev/b06a06ed4dc7
Allow TalosContentProfiler.js to pause and resume without initializing if the profiler should already be running in the parent. r=rwood
https://hg.mozilla.org/integration/autoland/rev/e0c5dbd138a3
Allow TalosContentProfiler.js to be loaded as both a frame script and as a normal DOM script. r=rwood
https://hg.mozilla.org/integration/autoland/rev/aae4e051c61e
Use TalosContentProfiler for profiling in tsvgx tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/72e2133c617f
Use TalosContentProfiler to fix profiling in tscroll tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/311f05e3ff83
Make pageloader start and capture profiles at better times. r=rwood
https://hg.mozilla.org/integration/autoland/rev/a9613f4f4be8
Use TalosParentProfiler to fix profiling in damp tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/1de718bbd836
Use TalosContentProfiler to fix profiling in glterrain tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/3e1b3238f26e
Use TalosContentProfiler to fix profiling in glvideo tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/312f82111594
Use TalosContentProfiler to fix profiling in tpaint tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/6a3f9d54a1af
Use TalosContentProfiler to fix profiling in tcanvasmark tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/5e37209d792a
Use TalosContentProfiler to fix profiling in basic_compositor_video tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/fc35f3255fdd
Use TalosContentProfiler to fix profiling in a11yr tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/1b9006ceb449
Use TalosContentProfiler to fix profiling in bloom_basic tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/835edc46b6c5
Ensure we get profiles for all content processes for tps by waiting until the profiles are gathered before closing the tabs. r=rwood
https://hg.mozilla.org/integration/autoland/rev/ba3597e894b0
Use TalosContentProfiler to fix profiling in kraken tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/02dac72b6dd0
Use TalosContentProfiler to fix profiling in dromaeo tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/c9fc3cee2393
Bump and sign new versions of TalosPowers, Pageloader, damp and tps. r=rwood

Comment 94

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/98897becd786
https://hg.mozilla.org/mozilla-central/rev/6f6b8285c422
https://hg.mozilla.org/mozilla-central/rev/b06a06ed4dc7
https://hg.mozilla.org/mozilla-central/rev/e0c5dbd138a3
https://hg.mozilla.org/mozilla-central/rev/aae4e051c61e
https://hg.mozilla.org/mozilla-central/rev/72e2133c617f
https://hg.mozilla.org/mozilla-central/rev/311f05e3ff83
https://hg.mozilla.org/mozilla-central/rev/a9613f4f4be8
https://hg.mozilla.org/mozilla-central/rev/1de718bbd836
https://hg.mozilla.org/mozilla-central/rev/3e1b3238f26e
https://hg.mozilla.org/mozilla-central/rev/312f82111594
https://hg.mozilla.org/mozilla-central/rev/6a3f9d54a1af
https://hg.mozilla.org/mozilla-central/rev/5e37209d792a
https://hg.mozilla.org/mozilla-central/rev/fc35f3255fdd
https://hg.mozilla.org/mozilla-central/rev/1b9006ceb449
https://hg.mozilla.org/mozilla-central/rev/835edc46b6c5
https://hg.mozilla.org/mozilla-central/rev/ba3597e894b0
https://hg.mozilla.org/mozilla-central/rev/02dac72b6dd0
https://hg.mozilla.org/mozilla-central/rev/c9fc3cee2393