Ensure all Talos Pageloader tests can return Gecko Profiles for all processes when run with --geckoProfiler

RESOLVED FIXED in Firefox 56

Status

Testing
Talos
P1
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-performance][qa-])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(19 attachments, 2 obsolete attachments)

59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
59 bytes, text/x-review-board-request
rwood
: review+
Details | Review
(Assignee)

Description

2 months ago
At least for tsvgx, we only return samples for the content process that the test runs in, which isn't always useful.

At the very least, we want the main thread in the parent process and compositor thread as well.
(Assignee)

Comment 1

2 months ago
I need this for bug 1357093.
Blocks: 1357093
Whiteboard: [photon-performance]
(Assignee)

Updated

2 months ago
Assignee: nobody → mconley

Updated

2 months ago
Whiteboard: [photon-performance] → [photon-performance] [triage]

Updated

2 months ago
Status: NEW → ASSIGNED
Iteration: --- → 56.1 - Jun 26
Priority: -- → P1
Whiteboard: [photon-performance] [triage] → [photon-performance]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Updated

2 months ago
Iteration: 56.1 - Jun 26 → 56.2 - Jul 10
Blocks: 1379188
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 months ago
Attachment #8880585 - Attachment is obsolete: true
(Assignee)

Updated

2 months ago
Attachment #8880586 - Attachment is obsolete: true
(Assignee)

Comment 14

2 months ago
There's still more work to do here, but I think these patches in my stack are pretty stable and can be reviewed now.

Comment 15

2 months ago
mozreview-review
Comment on attachment 8884447 [details]
Bug 1374333 - Allow TalosContentProfiler.js to pause and resume without initializing if the profiler should already be running in the parent.

https://reviewboard.mozilla.org/r/155358/#review160752
Attachment #8884447 - Flags: review?(rwood) → review+

Comment 16

2 months ago
mozreview-review
Comment on attachment 8884448 [details]
Bug 1374333 - Allow TalosContentProfiler.js to be loaded as both a frame script and as a normal DOM script.

https://reviewboard.mozilla.org/r/155360/#review160774
Attachment #8884448 - Flags: review?(rwood) → review+

Comment 17

2 months ago
mozreview-review
Comment on attachment 8880584 [details]
Bug 1374333 - TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded.

https://reviewboard.mozilla.org/r/151912/#review160780
Attachment #8880584 - Flags: review?(rwood) → review+

Comment 18

2 months ago
mozreview-review
Comment on attachment 8880581 [details]
Bug 1374333 - Make Pageloader use TalosParentProfiler.

https://reviewboard.mozilla.org/r/151906/#review160786

Looks great
Attachment #8880581 - Flags: review?(rwood) → review+

Comment 19

2 months ago
mozreview-review
Comment on attachment 8880582 [details]
Bug 1374333 - Use TalosContentProfiler for profiling in tsvgx tests.

https://reviewboard.mozilla.org/r/151908/#review160846

LGTM
Attachment #8880582 - Flags: review?(rwood) → review+

Comment 20

2 months ago
mozreview-review
Comment on attachment 8880583 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tscroll tests.

https://reviewboard.mozilla.org/r/151910/#review160862

Looks great!
Attachment #8880583 - Flags: review?(rwood) → review+

Updated

a month ago
Iteration: 56.2 - Jul 10 → 56.3 - Jul 24
(Assignee)

Updated

a month ago
Whiteboard: [photon-performance] → [photon-performance][qa-]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 59

a month ago
That last push was just a rebase.

Comment 60

a month ago
mozreview-review
Comment on attachment 8886400 [details]
Bug 1374333 - Make pageloader start and capture profiles at better times.

https://reviewboard.mozilla.org/r/157180/#review163554
Attachment #8886400 - Flags: review?(rwood) → review+

Comment 61

a month ago
mozreview-review
Comment on attachment 8886401 [details]
Bug 1374333 - Use TalosParentProfiler to fix profiling in damp tests.

https://reviewboard.mozilla.org/r/157182/#review163564
Attachment #8886401 - Flags: review?(rwood) → review+

Comment 62

a month ago
mozreview-review
Comment on attachment 8886402 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in glterrain tests.

https://reviewboard.mozilla.org/r/157184/#review163566
Attachment #8886402 - Flags: review?(rwood) → review+

Comment 63

a month ago
mozreview-review
Comment on attachment 8886403 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in glvideo tests.

https://reviewboard.mozilla.org/r/157186/#review163570
Attachment #8886403 - Flags: review?(rwood) → review+

Comment 64

a month ago
mozreview-review
Comment on attachment 8886404 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tpaint tests.

https://reviewboard.mozilla.org/r/157188/#review163572
Attachment #8886404 - Flags: review?(rwood) → review+

Comment 65

a month ago
mozreview-review
Comment on attachment 8886405 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in tcanvasmark tests.

https://reviewboard.mozilla.org/r/157190/#review163574
Attachment #8886405 - Flags: review?(rwood) → review+

Comment 66

a month ago
mozreview-review
Comment on attachment 8886406 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in basic_compositor_video tests.

https://reviewboard.mozilla.org/r/157192/#review163578
Attachment #8886406 - Flags: review?(rwood) → review+

Comment 67

a month ago
mozreview-review
Comment on attachment 8886407 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in a11yr tests.

https://reviewboard.mozilla.org/r/157194/#review163580
Attachment #8886407 - Flags: review?(rwood) → review+

Comment 68

a month ago
mozreview-review
Comment on attachment 8886408 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in bloom_basic tests.

https://reviewboard.mozilla.org/r/157196/#review163582
Attachment #8886408 - Flags: review?(rwood) → review+

Comment 69

a month ago
mozreview-review
Comment on attachment 8886409 [details]
Bug 1374333 - Ensure we get profiles for all content processes for tps by waiting until the profiles are gathered before closing the tabs.

https://reviewboard.mozilla.org/r/157198/#review163600
Attachment #8886409 - Flags: review?(rwood) → review+

Comment 70

a month ago
mozreview-review
Comment on attachment 8886410 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in kraken tests.

https://reviewboard.mozilla.org/r/157200/#review163608
Attachment #8886410 - Flags: review?(rwood) → review+

Comment 71

a month ago
mozreview-review
Comment on attachment 8886411 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in dromaeo tests.

https://reviewboard.mozilla.org/r/157202/#review163610

::: testing/talos/talos/tests/dromaeo/webrunner.js:128
(Diff revision 2)
> -				}
> +					}
>  
> -				if ( pos < numTests ) {
> +					TalosContentProfiler.pause(name, true).then(() => {
> +					  // For making Median and Variance
> +					  if (runStyle === "runs/s") {
> +					  	times.push((runs * 1000) / (cur - start));

nit whitespace

::: testing/talos/talos/tests/dromaeo/webrunner.js:130
(Diff revision 2)
> -				if ( pos < numTests ) {
> +					TalosContentProfiler.pause(name, true).then(() => {
> +					  // For making Median and Variance
> +					  if (runStyle === "runs/s") {
> +					  	times.push((runs * 1000) / (cur - start));
> +					  } else {
> +					  	times.push(cur - start);

nit whitespace

::: testing/talos/talos/tests/dromaeo/webrunner.js:153
(Diff revision 2)
> -								
> +
>  				    	logTest(data);
> -			
> +
>  				    	dequeue();
> -				}
> +					}
> +          });

I'm a bit confused about the alignment here but probably just how it's displayed in mozreview perhaps
Attachment #8886411 - Flags: review?(rwood) → review+

Comment 72

a month ago
mozreview-review
Comment on attachment 8886412 [details]
Bug 1374333 - Bump and sign new versions of TalosPowers, Pageloader, damp and tps.

https://reviewboard.mozilla.org/r/157204/#review163628
Attachment #8886412 - Flags: review?(rwood) → review+
(Assignee)

Comment 73

a month ago
mozreview-review-reply
Comment on attachment 8886411 [details]
Bug 1374333 - Use TalosContentProfiler to fix profiling in dromaeo tests.

https://reviewboard.mozilla.org/r/157202/#review163610

> I'm a bit confused about the alignment here but probably just how it's displayed in mozreview perhaps

Ah - this file used tabs for spacing, and my editor was hiding that for some reason. Thanks! Will fix before landing.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 93

a month ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98897becd786
TalosParentProfiler should be initted if the Gecko Profiler is already active when loaded. r=rwood
https://hg.mozilla.org/integration/autoland/rev/6f6b8285c422
Make Pageloader use TalosParentProfiler. r=rwood
https://hg.mozilla.org/integration/autoland/rev/b06a06ed4dc7
Allow TalosContentProfiler.js to pause and resume without initializing if the profiler should already be running in the parent. r=rwood
https://hg.mozilla.org/integration/autoland/rev/e0c5dbd138a3
Allow TalosContentProfiler.js to be loaded as both a frame script and as a normal DOM script. r=rwood
https://hg.mozilla.org/integration/autoland/rev/aae4e051c61e
Use TalosContentProfiler for profiling in tsvgx tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/72e2133c617f
Use TalosContentProfiler to fix profiling in tscroll tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/311f05e3ff83
Make pageloader start and capture profiles at better times. r=rwood
https://hg.mozilla.org/integration/autoland/rev/a9613f4f4be8
Use TalosParentProfiler to fix profiling in damp tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/1de718bbd836
Use TalosContentProfiler to fix profiling in glterrain tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/3e1b3238f26e
Use TalosContentProfiler to fix profiling in glvideo tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/312f82111594
Use TalosContentProfiler to fix profiling in tpaint tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/6a3f9d54a1af
Use TalosContentProfiler to fix profiling in tcanvasmark tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/5e37209d792a
Use TalosContentProfiler to fix profiling in basic_compositor_video tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/fc35f3255fdd
Use TalosContentProfiler to fix profiling in a11yr tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/1b9006ceb449
Use TalosContentProfiler to fix profiling in bloom_basic tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/835edc46b6c5
Ensure we get profiles for all content processes for tps by waiting until the profiles are gathered before closing the tabs. r=rwood
https://hg.mozilla.org/integration/autoland/rev/ba3597e894b0
Use TalosContentProfiler to fix profiling in kraken tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/02dac72b6dd0
Use TalosContentProfiler to fix profiling in dromaeo tests. r=rwood
https://hg.mozilla.org/integration/autoland/rev/c9fc3cee2393
Bump and sign new versions of TalosPowers, Pageloader, damp and tps. r=rwood

Comment 94

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/98897becd786
https://hg.mozilla.org/mozilla-central/rev/6f6b8285c422
https://hg.mozilla.org/mozilla-central/rev/b06a06ed4dc7
https://hg.mozilla.org/mozilla-central/rev/e0c5dbd138a3
https://hg.mozilla.org/mozilla-central/rev/aae4e051c61e
https://hg.mozilla.org/mozilla-central/rev/72e2133c617f
https://hg.mozilla.org/mozilla-central/rev/311f05e3ff83
https://hg.mozilla.org/mozilla-central/rev/a9613f4f4be8
https://hg.mozilla.org/mozilla-central/rev/1de718bbd836
https://hg.mozilla.org/mozilla-central/rev/3e1b3238f26e
https://hg.mozilla.org/mozilla-central/rev/312f82111594
https://hg.mozilla.org/mozilla-central/rev/6a3f9d54a1af
https://hg.mozilla.org/mozilla-central/rev/5e37209d792a
https://hg.mozilla.org/mozilla-central/rev/fc35f3255fdd
https://hg.mozilla.org/mozilla-central/rev/1b9006ceb449
https://hg.mozilla.org/mozilla-central/rev/835edc46b6c5
https://hg.mozilla.org/mozilla-central/rev/ba3597e894b0
https://hg.mozilla.org/mozilla-central/rev/02dac72b6dd0
https://hg.mozilla.org/mozilla-central/rev/c9fc3cee2393
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1382638
You need to log in before you can comment on or make changes to this bug.