137440 - DownloadManager should appear by default, rather than separate progress dialogs

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Peter Trudelle]

Shouldn't the download manager window appear by default rather than individual
progress dialogs?  I think this was implicit in the spec, but perhaps it should
have been more explicit.  Since this is a new feature, how are users to discover
it if we don't show it to them first?

Comment 1

[Peter Trudelle]

nsbeta1+/ADT1 per Nav triage team. ->1.0

Comment 2

[Blake Ross]

adding eta.

Comment 3

[sairuh (rarely reading bugmail)]

if this is implemented, how would this behave for the case of helper
applications? see bug 132456 comment 8.

Comment 4

[Blake Ross]

Attachment: patch

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 80328 [details] [diff] [review]
patch

SR=[e-mail]

Comment 6

[Hixie (not reading bugmail)]

Comment on attachment 80328 [details] [diff] [review]
patch

R=[e-mail]

Comment 7

[tao]

Hi, Blaker:

Would you please explain in 121324 how this pref works?

+pref("browser.downloadmanager.behavior", 0);


thx

Comment 8

[scottputterman]

adding adt1.0.0-.  The ADT decided that there were enough known issues with
download manager that we shouldn't turn it on by default for beta. In addition,
it's pretty late to be turning this on by default.

Comment 9

[Blake Ross]

Um, okay, can ADT elaborate on what these known issues are?  Since the two it
plussed earlier today aren't really bugs?

Comment 10

[Blake Ross]

checked in on trunk. marking fixed.

Comment 11

[Blake Ross]

forgot to mention...I overrode the pref on mac for now to keep showing the
progress dialog, until we fix bug 132027.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Hey, could we also add a comment to all.js that basically says what Blake says
in Bug 121324, comment 9?

Comment 13

[sairuh (rarely reading bugmail)]

using 2002.04.29-trunk comm builds:

on win2k and linux rh7.2, the dl mgr now opens by default instead of the
old-style progress dlg (verifying this fix). on mac 10.1.4, the progress dlg
still appears by default (as expected).

however, bug 132456 is still a problem, at least on win32 and unix where dl mgr
will open by default: the download mgr will still open if you open a file with a
helper application (instead of saving it).

Comment 14

[Jonathan Wilson]

I have been reading all this stuff and as far as I can tell, this isnt in the
branch because the people at netscape dont think the download manager should be
turned on for 1.0 (at least thats what it looks like to me)
How about adding the code to the 1.0 branch but having the pref about it
defaulting to off. That way people that are prepared to put up with the bugs &
stuff in the download manager and who want to use it by default can turn it on
in user.js if they really want to.

Acording to the current all.js in LXR the current default for the trunk is to
make the download manager appear. What I am suggesting is that the code
attatched to this bug goes into the branch but the pref is set to 1 instead of 0
in all.js

Is there some reason this idea is a bad one?

Comment 15

[Markus Hübner]

Think this is a great idea and should be done that way in 1.0 final.

Comment 16

[sairuh (rarely reading bugmail)]

really marking vrfy'd fixed [for the TRUNK].