Closed
Bug 1374419
Opened 8 years ago
Closed 8 years ago
Make gHistograms constexpr to remove its initializer
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
For whatever reason, MSVC is emitting a 230K function to initialize gHistograms at startup. It can be avoided by marking gHistograms as constexpr.
Assignee: nobody → dmajor
Attachment #8879299 -
Flags: review?(gfritzsche)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8879299 [details] [diff] [review]
patch
Review of attachment 8879299 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
This will enable properly doing the static asserts here:
https://dxr.mozilla.org/mozilla-central/rev/416c3c8c4b3db9ba96a103ce7820c9a140a3051d/toolkit/components/telemetry/TelemetryHistogram.cpp#1890
I'll file a follow-up on that.
Attachment #8879299 -
Flags: review?(gfritzsche) → review+
|
|
||
Updated•8 years ago
|
Priority: -- → P2
|
|
||
Updated•8 years ago
|
Priority: P2 → P1
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57a2424a75e8
Make gHistograms constexpr to remove its initializer. r=gfritzsche
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•