1374443 - Decrease HSTS priming timeout to 2000ms

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P1)

Description

[Kate McKinley [:kmckinley, :Kate]]

Update the default preference for security.mixed_content.hsts_priming_request_timeout to 2000ms.

Comment 1

[Kate McKinley [:kmckinley, :Kate]]

Attachment: Bug 1374443 - Decrease HSTS priming timeout to 2s

Review commit: https://reviewboard.mozilla.org/r/150590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150590/

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8879311 [details]
Bug 1374443 - Decrease HSTS priming timeout to 2s

https://reviewboard.mozilla.org/r/150590/#review155524

thanks kate, please fix my nit and then this is ready to go.

::: netwerk/protocol/http/HSTSPrimerListener.cpp:34
(Diff revision 1)
>  
>  NS_IMPL_ISUPPORTS(HSTSPrimingListener, nsIStreamListener,
>                    nsIRequestObserver, nsIInterfaceRequestor,
>                    nsITimerCallback)
>  
> -// default to 3000ms, same as the preference
> +// default to 2000ms, same as the preference

Nit: Please add the pref name ("security.mixed_content.hsts_priming_request_timeout") in the comment as well so people updating the pref in the future know that they have to update that hardcoded value as well.

Comment 3

[Kate McKinley [:kmckinley, :Kate]]

Comment on attachment 8879311 [details]
Bug 1374443 - Decrease HSTS priming timeout to 2s

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150590/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71ece2c1e68d
Decrease HSTS priming timeout to 2s r=ckerschb

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/71ece2c1e68d