Closed
Bug 1374443
Opened 8 years ago
Closed 8 years ago
Decrease HSTS priming timeout to 2000ms
Categories
(Core :: DOM: Security, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kmckinley, Assigned: kmckinley)
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
Update the default preference for security.mixed_content.hsts_priming_request_timeout to 2000ms.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8879311 [details]
Bug 1374443 - Decrease HSTS priming timeout to 2s
https://reviewboard.mozilla.org/r/150590/#review155524
thanks kate, please fix my nit and then this is ready to go.
::: netwerk/protocol/http/HSTSPrimerListener.cpp:34
(Diff revision 1)
>
> NS_IMPL_ISUPPORTS(HSTSPrimingListener, nsIStreamListener,
> nsIRequestObserver, nsIInterfaceRequestor,
> nsITimerCallback)
>
> -// default to 3000ms, same as the preference
> +// default to 2000ms, same as the preference
Nit: Please add the pref name ("security.mixed_content.hsts_priming_request_timeout") in the comment as well so people updating the pref in the future know that they have to update that hardcoded value as well.
Attachment #8879311 -
Flags: review?(ckerschb) → review+
Updated•8 years ago
|
Priority: -- → P1
Whiteboard: [domsecurity-active]
Comment hidden (mozreview-request) |
Pushed by kmckinley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71ece2c1e68d
Decrease HSTS priming timeout to 2s r=ckerschb
Comment 5•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•