Closed Bug 1374443 Opened 5 years ago Closed 5 years ago

Decrease HSTS priming timeout to 2000ms

Categories

(Core :: DOM: Security, enhancement, P1)

Product:
Core
Component:
DOM: Security
Version:
56 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: kmckinley, Assigned: kmckinley)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

Bug 1374443 - Decrease HSTS priming timeout to 2s
59 bytes, text/x-review-board-request
ckerschb
: review+
Details 
Update the default preference for security.mixed_content.hsts_priming_request_timeout to 2000ms.
Comment on attachment 8879311 [details]
Bug 1374443 - Decrease HSTS priming timeout to 2s

https://reviewboard.mozilla.org/r/150590/#review155524

thanks kate, please fix my nit and then this is ready to go.

::: netwerk/protocol/http/HSTSPrimerListener.cpp:34
(Diff revision 1)
>  
>  NS_IMPL_ISUPPORTS(HSTSPrimingListener, nsIStreamListener,
>                    nsIRequestObserver, nsIInterfaceRequestor,
>                    nsITimerCallback)
>  
> -// default to 3000ms, same as the preference
> +// default to 2000ms, same as the preference

Nit: Please add the pref name ("security.mixed_content.hsts_priming_request_timeout") in the comment as well so people updating the pref in the future know that they have to update that hardcoded value as well.
Attachment #8879311 - Flags: review?(ckerschb) → review+
Priority: -- → P1
Whiteboard: [domsecurity-active]
Pushed by kmckinley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71ece2c1e68d
Decrease HSTS priming timeout to 2s r=ckerschb
https://hg.mozilla.org/mozilla-central/rev/71ece2c1e68d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.