1374494 - Update cubeb-pulse-rs to to 6451581

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P2)

Description

[u480271]

Rustified bindings with rusty idioms.

Comment 1

[u480271]

Attachment: Bug 1374494 - P1: Add pulse-rs folder to update.sh.

Review commit: https://reviewboard.mozilla.org/r/150670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150670/

Comment 2

[u480271]

Attachment: Bug 1374494 - P2: Update cubeb-pulse-rs to commit djg/cubeb-pulse-rs/6451581.

Review commit: https://reviewboard.mozilla.org/r/150672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150672/

Comment 3

[u480271]

Attachment: Bug 1374494 - P3: Run ./mach vendor rust.

Should this be folded into another commit?

Review commit: https://reviewboard.mozilla.org/r/150674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150674/

Comment 4

[u480271]

Previous try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e45dbf6670dd5d9357c55e1d204ee7a3b68a0842

Comment 5

[u480271]

Ralph,

I put a comment in the rust vendor check-in, but should this be separate or folded into the code update?

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8879367 [details]
Bug 1374494 - P2: Update cubeb-pulse-rs to commit djg/cubeb-pulse-rs/6451581.

https://reviewboard.mozilla.org/r/150672/#review155406

Comment 7

[Matthew Gregan [:kinetik]]

Comment on attachment 8879366 [details]
Bug 1374494 - P1: Add pulse-rs folder to update.sh.

https://reviewboard.mozilla.org/r/150670/#review155408

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8879368 [details]
Bug 1374494 - P3: Run ./mach vendor rust.

https://reviewboard.mozilla.org/r/150674/#review155956

::: commit-message-b897b:3
(Diff revision 1)
> +Bug 1374494 - P3: Run ./mach vendor rust. r?rillian
> +
> +Should this be folded into another commit?

Probably. I don't care either way. Bisection works better if it's part of the code update, which probably trumps more discrete history hereg.

Comment 9

[u480271]

(In reply to Ralph Giles (:rillian) | needinfo me from comment #8)
> Comment on attachment 8879368 [details]
> Bug 1374494 - P3: Run ./mach vendor rust.
> 
> https://reviewboard.mozilla.org/r/150674/#review155956
> 
> ::: commit-message-b897b:3
> (Diff revision 1)
> > +Bug 1374494 - P3: Run ./mach vendor rust. r?rillian
> > +
> > +Should this be folded into another commit?
> 
> Probably. I don't care either way. Bisection works better if it's part of
> the code update, which probably trumps more discrete history hereg.

thanks Ralph. I'll fold it into the code update commit.

Comment 10

[u480271]

Comment on attachment 8879366 [details]
Bug 1374494 - P1: Add pulse-rs folder to update.sh.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150670/diff/1-2/

Comment 11

[u480271]

Comment on attachment 8879367 [details]
Bug 1374494 - P2: Update cubeb-pulse-rs to commit djg/cubeb-pulse-rs/6451581.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150672/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c50728ccbc3d
P1: Add pulse-rs folder to update.sh. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/5ff54dc9d0ad
P2: Update cubeb-pulse-rs to commit djg/cubeb-pulse-rs/6451581. r=kinetik

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c50728ccbc3d
https://hg.mozilla.org/mozilla-central/rev/5ff54dc9d0ad

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Note - this is needed to build Firefox 55 on ARM.