Closed Bug 1374538 Opened 3 years ago Closed 3 years ago

Bug 1310197 produces a a broken configure.in

Categories

(NSPR :: NSPR, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gaston, Assigned: dragana)

References

Details

Attachments

(1 file)

https://hg.mozilla.org/projects/nspr/diff/f39f28732459/configure.in lacks a 'fi' to close the if that was added there, resulting in a broken configure script if autoconf is run from the released 4.15 tarball.

'./configure[6682]: syntax error: `;;' unexpected   ' 

Adding the missing 'fi' allows autoconf to produce a valid configure script.
Blocks: 1310197
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Attachment #8879468 - Flags: review?(kaie)
Comment on attachment 8879468 [details] [diff] [review]
bug_1374538.patch

I have the same thing locally to fixit - but i think your patch should be against https://hg.mozilla.org/projects/nspr and not https://hg.mozilla.org/mozilla-central. Code lands into nspr repo then gets uplifted to central/inbound/etc
Attachment #8879468 - Flags: review?(kaie) → review+
Checked in to both NSPR trunk and 4.15 branch:
https://hg.mozilla.org/projects/nspr/rev/b928b8892225
https://hg.mozilla.org/projects/nspr/rev/593fb28f2c21

Why didn't we run into this error earlier, are some versions of the autoconf scripts tolerant against this mistake?

Should we release an 4.15.1 release with this fix?
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.16
You need to log in before you can comment on or make changes to this bug.