1374561 - Allow to set log level in mach for every class derived from MozbuildObject

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Andi [:andi]]

For every functionality/ command that we implement in mach it would be nice to set independently the log level. 

For this my resolution would be to move:

>>    def _set_log_level(self, verbose):
>>        self.log_manager.terminal_handler.setLevel(logging.INFO if not verbose else logging.DEBUG)

From |PackageFrontend| to | MozbuildObject| because every new functionality/ command.

Comment 1

[Mike Hommey [:glandium]]

Note that when I said separate patch, I didn't mean a separate bug.

Comment 2

[Andi [:andi]]

(In reply to Mike Hommey [:glandium] from comment #1)
> Note that when I said separate patch, I didn't mean a separate bug.

I thought we can track it more easy if i add a separate bug for this. Is it ok on your side if i upload it here?

Comment 3

[Andi [:andi]]

Attachment: Bug 1374561 - Allow to set log level in mach for every class derived from MozbuildObject.

Review commit: https://reviewboard.mozilla.org/r/150768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150768/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8879457 [details]
Bug 1374561 - Allow to set log level in mach for every class derived from MozbuildObject.

https://reviewboard.mozilla.org/r/150768/#review155968

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b36dbe9b2a3
Allow to set log level in mach for every class derived from MozbuildObject. r=glandium

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b36dbe9b2a3