1374599 - test_bookmark_engine.js is susceptible to random oranges

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Banner (:standard8)]

As discovered in bug 1095426 (comments 52 - 55) test_bookmark_engine.js is susceptible to random oranges.

We should investigate what is the cause of a different sync end time being set in some cases, as it is likely that multiple syncs are being triggered unexpectedly or they aren't being completed at the expected times.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1374599 - neuter the sync scheduler during some tests to avoid oranges.

Review commit: https://reviewboard.mozilla.org/r/151200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151200/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34d120b770a7f041a2ab528edd060cfa08952646 is a try with Mark's old patch which triggered oranges regularly - ignore the eslint errors, that was a bad merge on my part . I'll retrigger the xpcshell tests a number of times, but without this patch I would see around 50% of the tests be orange.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8879805 [details]
Bug 1374599 - neuter the sync scheduler during some tests to avoid oranges.

https://reviewboard.mozilla.org/r/151200/#review156142

Looks good, definitely feels like the right thing to do & seems to solve the intermittent :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fbf2ee56e34
neuter the sync scheduler during some tests to avoid oranges. r=standard8

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6fbf2ee56e34