test_bookmark_engine.js is susceptible to random oranges

RESOLVED FIXED in Firefox 56

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: markh)

Tracking

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
As discovered in bug 1095426 (comments 52 - 55) test_bookmark_engine.js is susceptible to random oranges.

We should investigate what is the cause of a different sync end time being set in some cases, as it is likely that multiple syncs are being triggered unexpectedly or they aren't being completed at the expected times.
Assignee

Updated

2 years ago
See Also: → 1374829
Assignee

Comment 2

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=34d120b770a7f041a2ab528edd060cfa08952646 is a try with Mark's old patch which triggered oranges regularly - ignore the eslint errors, that was a bad merge on my part . I'll retrigger the xpcshell tests a number of times, but without this patch I would see around 50% of the tests be orange.
Assignee: nobody → markh
Reporter

Updated

2 years ago
Blocks: 1374829
Reporter

Updated

2 years ago
Attachment #8879805 - Flags: review?(kit) → review?(standard8)
Reporter

Comment 3

2 years ago
mozreview-review
Comment on attachment 8879805 [details]
Bug 1374599 - neuter the sync scheduler during some tests to avoid oranges.

https://reviewboard.mozilla.org/r/151200/#review156142

Looks good, definitely feels like the right thing to do & seems to solve the intermittent :-)
Attachment #8879805 - Flags: review?(standard8) → review+

Comment 4

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fbf2ee56e34
neuter the sync scheduler during some tests to avoid oranges. r=standard8

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6fbf2ee56e34
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.