Closed Bug 1374599 Opened 4 years ago Closed 4 years ago

test_bookmark_engine.js is susceptible to random oranges

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: standard8, Assigned: markh)

References

Details

Attachments

(1 file)

As discovered in bug 1095426 (comments 52 - 55) test_bookmark_engine.js is susceptible to random oranges.

We should investigate what is the cause of a different sync end time being set in some cases, as it is likely that multiple syncs are being triggered unexpectedly or they aren't being completed at the expected times.
See Also: → 1374829
https://treeherder.mozilla.org/#/jobs?repo=try&revision=34d120b770a7f041a2ab528edd060cfa08952646 is a try with Mark's old patch which triggered oranges regularly - ignore the eslint errors, that was a bad merge on my part . I'll retrigger the xpcshell tests a number of times, but without this patch I would see around 50% of the tests be orange.
Assignee: nobody → markh
Blocks: 1374829
Attachment #8879805 - Flags: review?(kit) → review?(standard8)
Comment on attachment 8879805 [details]
Bug 1374599 - neuter the sync scheduler during some tests to avoid oranges.

https://reviewboard.mozilla.org/r/151200/#review156142

Looks good, definitely feels like the right thing to do & seems to solve the intermittent :-)
Attachment #8879805 - Flags: review?(standard8) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fbf2ee56e34
neuter the sync scheduler during some tests to avoid oranges. r=standard8
https://hg.mozilla.org/mozilla-central/rev/6fbf2ee56e34
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.