1374614 - Support SVG image context paint in XUL tree views (treecol etc.)

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Comment 1

[Jonathan Watt [:jwatt]]

This requires passing the relevant frame to nsLayoutUtils::DrawImage so that it can create an SVGImageContext. Actually, it's not quite that simple because tree view images are generally displayed as part of a pseudo-element. So actually we need to pass through the nsStyleContext for the pseudo-element. That then requires an overload of MaybeStoreContextPaint to support passing an nsStyleContext rather than an nsIFrame.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8879520 [details] [diff] [review]
patch

Review of attachment 8879520 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsLayoutUtils.h
@@ +1808,5 @@
>     *   @param aRenderingContext Where to draw the image, set up with an
>     *                            appropriate scale and transform for drawing in
>     *                            app units.
> +   *   @param aStyleContext     The style context of the nsIFrame, or one of the
> +   *                            nsIFrame's pseudo-elements, for which this image

Per IRC, let's simplify this to just:

 "...of the nsIFrame (or pseudo-element) for which..."

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4527074703e6
Support SVG image context paint in XUL tree views (treecol etc.). r=dholbert

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4527074703e6