1374620 - Enable the ESLint dot-notation rule across mozilla-central

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

We currently have dot-notation enabled for a few directories, but we should expand it to the whole of the repository.

I'm happy to mentor this bug. There's background on our eslint setups here:

https://developer.mozilla.org/docs/ESLint

Also, details of the rule: http://eslint.org/docs/rules/dot-notation

Here's some approximate steps:

- Add a dot-notation (error) line in recommended.js.
- Remove the dot-notation related lines in the existing .eslintrc.js configs (apart from devtools/):

https://dxr.mozilla.org/mozilla-central/search?q=dot-notation&redirect=false

- Run eslint for fixing:

./mach eslint --fix

This should fix most/all of the instances.

- Fix any remaining instances by hand
- Inspect the diff to make sure that the indentation of the lines surrounding the changes look ok.
- Create a commit and push it to mozreview:

http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview.html

Comment 1

[Rajesh Kathiriya(:rajk)]

I will work on this.

Comment 2

[Rajesh Kathiriya(:rajk)]

Attachment: Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central

Review commit: https://reviewboard.mozilla.org/r/161060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161060/

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8891896 [details]
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central

https://reviewboard.mozilla.org/r/161060/#review168276

Looks good. I'm currently running this through try to check for any unforseen issues, but assuming it passes we're good to go - I'll push it if it does pass.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5922a7ed25a
Enabled the ESLint dot-notation rule across mozilla-central r=standard8

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry, this had to be backed out for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation:

https://hg.mozilla.org/integration/autoland/rev/3fcd58db9fd775d32e43c23e571bff474600d41c

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f5922a7ed25a9aa0683f57bb43e2a53709c385ee&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=119553107&repo=autoland
> TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/components/telemetry/tests/unit/test_TelemetrySend.js:358:33 | ["os"] is better written in dot notation. (dot-notation)

Please fix the issue and submit an updated patch. Thank you.

Comment 6

[Mark Banner (:standard8)]

Rajesh: it looks like that test landed in the last few days. If you can rebase the patch and fix it, we'll hopefully be good to go.

Comment 7

[Rajesh Kathiriya(:rajk)]

Comment on attachment 8891896 [details]
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161060/diff/1-2/

Comment 8

[Mark Banner (:standard8)]

Unfortunately it appears that there's already something that has bitrotted on autoland. I'll work with Sheriffs in the morning (probably after the merges), to see if we can get this landed during a quiet period.

Comment 9

[Mark Banner (:standard8)]

Attachment: Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central

Review commit: https://reviewboard.mozilla.org/r/163884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163884/

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8892869 [details]
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central

https://reviewboard.mozilla.org/r/163884/#review169206

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ca118eb2eb6
Enabled the ESLint dot-notation rule across mozilla-central r=standard8

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ca118eb2eb6

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/7fe743b1a3ea139c3bac306be0dced4948f0f732
Merge pull request #953 from Osmose/dot-notation-lint

Bug 1374620 - Fix dot-notation lint errors.

Comment 14

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/2ca118eb2eb6329d939677c308742d266f813dc5
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8