Closed
Bug 1374620
Opened 7 years ago
Closed 7 years ago
Enable the ESLint dot-notation rule across mozilla-central
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: standard8, Assigned: rajk, Mentored)
References
()
Details
(Whiteboard: [lang=js])
Attachments
(1 file, 1 obsolete file)
We currently have dot-notation enabled for a few directories, but we should expand it to the whole of the repository. I'm happy to mentor this bug. There's background on our eslint setups here: https://developer.mozilla.org/docs/ESLint Also, details of the rule: http://eslint.org/docs/rules/dot-notation Here's some approximate steps: - Add a dot-notation (error) line in recommended.js. - Remove the dot-notation related lines in the existing .eslintrc.js configs (apart from devtools/): https://dxr.mozilla.org/mozilla-central/search?q=dot-notation&redirect=false - Run eslint for fixing: ./mach eslint --fix This should fix most/all of the instances. - Fix any remaining instances by hand - Inspect the diff to make sure that the indentation of the lines surrounding the changes look ok. - Create a commit and push it to mozreview: http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview.html
Assignee | ||
Comment 1•7 years ago
|
||
I will work on this.
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → rajesh.kathiriya507
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8891896 [details] Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central https://reviewboard.mozilla.org/r/161060/#review168276 Looks good. I'm currently running this through try to check for any unforseen issues, but assuming it passes we're good to go - I'll push it if it does pass.
Attachment #8891896 -
Flags: review?(standard8) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5922a7ed25a Enabled the ESLint dot-notation rule across mozilla-central r=standard8
Comment 5•7 years ago
|
||
Sorry, this had to be backed out for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation: https://hg.mozilla.org/integration/autoland/rev/3fcd58db9fd775d32e43c23e571bff474600d41c Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f5922a7ed25a9aa0683f57bb43e2a53709c385ee&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=119553107&repo=autoland > TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/components/telemetry/tests/unit/test_TelemetrySend.js:358:33 | ["os"] is better written in dot notation. (dot-notation) Please fix the issue and submit an updated patch. Thank you.
Flags: needinfo?(rajesh.kathiriya507)
Reporter | ||
Comment 6•7 years ago
|
||
Rajesh: it looks like that test landed in the last few days. If you can rebase the patch and fix it, we'll hopefully be good to go.
Comment hidden (mozreview-request) |
Reporter | ||
Comment 8•7 years ago
|
||
Unfortunately it appears that there's already something that has bitrotted on autoland. I'll work with Sheriffs in the morning (probably after the merges), to see if we can get this landed during a quiet period.
Flags: needinfo?(rajesh.kathiriya507)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8892869 [details] Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central https://reviewboard.mozilla.org/r/163884/#review169206
Attachment #8892869 -
Flags: review?(standard8) → review+
Comment 11•7 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ca118eb2eb6 Enabled the ESLint dot-notation rule across mozilla-central r=standard8
Reporter | ||
Updated•7 years ago
|
Attachment #8891896 -
Attachment is obsolete: true
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2ca118eb2eb6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 13•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/normandy https://github.com/mozilla/normandy/commit/7fe743b1a3ea139c3bac306be0dced4948f0f732 Merge pull request #953 from Osmose/dot-notation-lint Bug 1374620 - Fix dot-notation lint errors.
Comment 14•7 years ago
|
||
https://hg.mozilla.org/projects/date/rev/2ca118eb2eb6329d939677c308742d266f813dc5 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
Updated•6 years ago
|
Product: Testing → Firefox Build System
Updated•5 years ago
|
Keywords: good-first-bug
Version: Version 3 → 3 Branch
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•