1374637 - Don't allow the legacy extensions tab to load if it is empty

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: 2017-06-20_1526.png

[Affected versions]:
Firefox 56.0a1 (2017-06-19)
Firefox 55.0b2 (20170615063713)
 
[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.12.1
 
[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install several legacy add-ons.
3.Navigate to about:config and toggle the value of extensions.legacy.enabled to false.
4.Go to Add-ons Manager -> Legacy Extensions and remove all the add-ons.
5.Restart the browser while focusing the “Legacy Extensions” tab.
 
[Expected Results]:
Get add-ons/Extensions tab is focused after a browser restart.
 
 
[Actual Results]:
- A broken “Legacy Extensions” page is displayed and the tab misses from the Add-ons Manager list.
- See attached screenshot.

Comment 1

[Andrew Swan [:aswan]]

about:addons carefully remembers the last pane you were visiting and reloads it when you go back to about:addons.  But there are several scenarios (including the one in the description of this bug) where you can end up at that page without any legacy extensions installed.  We should probably just revert to the main Extensions pane in this case.

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1374637 Don't show the Legacy Extensions pane in about:addons if it is empty

Review commit: https://reviewboard.mozilla.org/r/158676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158676/

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 8887758 [details]
Bug 1374637 Don't show the Legacy Extensions pane in about:addons if it is empty

https://reviewboard.mozilla.org/r/158676/#review164276

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0da00124af43
Don't show the Legacy Extensions pane in about:addons if it is empty r=rhelmer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0da00124af43

Comment 6

[Vasilica Tamas, QA [:vtamas]]

Confirm that this issue is fixed on Firefox 56.0a1 (2017-07-25/26) under Windows 10 64-bit and Mac OS X 10.12.3. The “Extensions” tab is successfully focused after a browser restart.