1374729 - Don't treat R8G8B8X8 the same as B8G8R8X8

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Quoting Jeff Muizelaar [:jrmuizel] from bug 1373381 comment 22:

> Comment on attachment 8879557 [details]
> Bug 1373381 - Update RGBA8 to BGRA8 since it was renamed in WR cset 264d53d.
> 
> https://reviewboard.mozilla.org/r/150866/#review155636
> 
> ::: gfx/webrender_bindings/WebRenderTypes.h:54
> (Diff revision 1)
> >  inline Maybe<WrImageFormat>
> >  SurfaceFormatToWrImageFormat(gfx::SurfaceFormat aFormat) {
> >    switch (aFormat) {
> >      case gfx::SurfaceFormat::R8G8B8X8:
> >        // TODO: use RGBA + opaque flag
> > -      return Some(WrImageFormat::RGBA8);
> > +      return Some(WrImageFormat::BGRA8);
> 
> Not your problem but this should really be an assert. Treating R8G8B8X8 the
> same as B8G8R8X8 won't work.
> We can fix this after.

Filing this bug for the fix.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Use correct format for MacIOSurface.

MozReview-Commit-ID: 43JBSi5mqT7

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbaa2fb73a32fef3669bf976a8f8d2b8d24abdfc

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d37f5eba96ba
Use correct format for MacIOSurface. r=nical

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d37f5eba96ba