Closed Bug 1374729 Opened 2 years ago Closed 2 years ago

Don't treat R8G8B8X8 the same as B8G8R8X8

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected
firefox59 --- fixed

People

(Reporter: kats, Assigned: mtseng)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-reserve] [gfx-noted])

Attachments

(1 file)

Quoting Jeff Muizelaar [:jrmuizel] from bug 1373381 comment 22:

> Comment on attachment 8879557 [details]
> Bug 1373381 - Update RGBA8 to BGRA8 since it was renamed in WR cset 264d53d.
> 
> https://reviewboard.mozilla.org/r/150866/#review155636
> 
> ::: gfx/webrender_bindings/WebRenderTypes.h:54
> (Diff revision 1)
> >  inline Maybe<WrImageFormat>
> >  SurfaceFormatToWrImageFormat(gfx::SurfaceFormat aFormat) {
> >    switch (aFormat) {
> >      case gfx::SurfaceFormat::R8G8B8X8:
> >        // TODO: use RGBA + opaque flag
> > -      return Some(WrImageFormat::RGBA8);
> > +      return Some(WrImageFormat::BGRA8);
> 
> Not your problem but this should really be an assert. Treating R8G8B8X8 the
> same as B8G8R8X8 won't work.
> We can fix this after.

Filing this bug for the fix.
Priority: P3 → P2
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
Priority: P2 → P3
Whiteboard: [wr-mvp] [gfx-noted] → [wr-reserve] [gfx-noted]
Assignee: nobody → mtseng
MozReview-Commit-ID: 43JBSi5mqT7
Attachment #8940662 - Flags: review?(nical.bugzilla)
Attachment #8940662 - Flags: review?(nical.bugzilla) → review+
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d37f5eba96ba
Use correct format for MacIOSurface. r=nical
https://hg.mozilla.org/mozilla-central/rev/d37f5eba96ba
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.