Closed Bug 1374731 Opened 6 years ago Closed 6 years ago

Remove built-in Flash test tables


(Toolkit :: Safe Browsing, defect, P1)




56.1 - Jun 26
Tracking Status
firefox56 --- fixed


(Reporter: Felipe, Assigned: Felipe)


(Blocks 1 open bug)


(Whiteboard: [reserve-photon-performance])


(1 file)

On bug 1307604, the test entries from to test the flash blocking lists were added to the hardcoded list in SafeBrowsing.addMozEntries(), following the pattern of the other existing ones (from the malware/tracking-protection features).

However, all these Flash entries are present in the actual lists served by shavar, and it's been agreed that it's not necessary to have them hardcoded by the browser.

It's likely that this will represent a perf win, or at least open the way for one. When bug 1307604 landed, it caused bug 1337043. That regression was recovered by some other means, but removing this is strictly less work to be done on startup.

Also, I wish to remove more stuff from this in the future, but that involves more conversations, and this is the easy first step to get those conversations started.
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [photon-performance] → [reserve-photon-performance]
I wasn't sure if it was necessary to add the test tables to disallow completions during tests, so I added them just to be sure.
Comment on attachment 8879719 [details]
Bug 1374731 - Don't use hardcoded test entries for the Flash classification tables.

Looks good to me.
Attachment #8879719 - Flags: review?(ksteuber) → review+
Pushed by
Don't use hardcoded test entries for the Flash classification tables. r=bytesized
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Iteration: --- → 56.1 - Jun 26
BTW, next time we should ensure that one of the URL Classifier peers (Dimi, Henry, GCP or me) takes a look a the patch too before landing.

(I just had a look through it and it looks all good to me.)
You need to log in before you can comment on or make changes to this bug.