1374887 - nsFormFillController throws invisible exceptions when trying to call non-existing nsIFormAutoComplete::stopControllingInput function

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[(no longer active)]

Attachment: dump exceptions created

By adding the attached debugging patch you see us creating a bunch of invisible exceptions when running Speedometer, including this one:

Exception: JavaScript component does not have a method named: "stopControllingInput"'JavaScript component does not have a method named: "stopControllingInput"' when calling method: [nsIFormAutoComplete::stopControllingInput], 

It turns out that this function was removed from bug 1294502 <https://github.com/mozilla/gecko-dev/commit/c917d86d56b0d4004056c1a7eb97c7ba578c3333#diff-8828dcb4aa1c89082172cede49c2bb6dL545> and left the C++ side of this, which is now effectively an exception throwing machinery.  ;-)

Comment 1

[(no longer active)]

Attachment: Remove nsIFormAutoComplete::StopControllingInput() from the C++ side

This currently only incurs some XPConnect and exception creation
overhead, as the method has no implementation.

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8879780 [details] [diff] [review]
Remove nsIFormAutoComplete::StopControllingInput() from the C++ side

Review of attachment 8879780 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d082a79f1f
Remove nsIFormAutoComplete::StopControllingInput() from the C++ side; r=MattN

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41d082a79f1f