Closed Bug 1374889 Opened 4 years ago Closed 3 years ago

(Leanplum) Campaign : Log in to FxA - Default Browser Promotion

Categories

(Firefox for Android :: Metrics, enhancement)

56 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: cnevinchen, Assigned: cnevinchen)

References

Details

Attachments

(3 files)

Context:
Log in to FxA and show dialog to link to default browser settings

Trigger:
When a user just login.

Deep Link: 
Go to default browser settings if API Level >= 24 , other wise shwo SUMO page
Comment on attachment 8879884 [details]
Bug 1374889 - Update Leanplum user attribute for Focus/Klar installation, Sync, and Default Browser.

https://reviewboard.mozilla.org/r/151278/#review156230

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:48
(Diff revision 1)
> +        // So I'll make the check here every time when Leanplum initialized. And trigger FxAccount related
> +        // campaign lazily.

Your point is, in order to trigger the campaign lazily, you check the account existence as an attribute, not when account login success callback is invoked. Because the attribute update lazily when process start.

Your comment probably should address this more clear.

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:50
(Diff revision 1)
> +        if (!FirefoxAccounts.firefoxAccountsExist(activity)) {
> +            attributes.put("fxAccount", true);

Why are we having accounts NOT exist with putting attribute as true?

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:50
(Diff revision 1)
> +        if (!FirefoxAccounts.firefoxAccountsExist(activity)) {
> +            attributes.put("fxAccount", true);
Attachment #8879884 - Flags: review?(max) → review-
I'm going to add another user attribute "DefaultBrowser". This will need to update the document before it lands.
Waiting for Bug 1373174 to land. So I can add document about above changes.
Depends on: 1373174
Comment on attachment 8879884 [details]
Bug 1374889 - Update Leanplum user attribute for Focus/Klar installation, Sync, and Default Browser.

https://reviewboard.mozilla.org/r/151278/#review156544

LGTM
Attachment #8879884 - Flags: review?(max) → review+
Comment on attachment 8880209 [details]
Bug 1374889 - Update Leanplum document for Focus/Klar installation, Sync,Default Browser user attribute.

https://reviewboard.mozilla.org/r/151574/#review156546

LGTM
Attachment #8880209 - Flags: review?(max) → review+
Please help review again. Thank you!
Flags: needinfo?(max)
Flags: needinfo?(liuche)
Comment on attachment 8880209 [details]
Bug 1374889 - Update Leanplum document for Focus/Klar installation, Sync,Default Browser user attribute.

https://reviewboard.mozilla.org/r/151574/#review159758

Adding more probes for specific relevant apps being installed, lgtm
Attachment #8880209 - Flags: review?(liuche) → review+
Flags: needinfo?(liuche)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3f43bcfc1ec2
Update Leanplum user attribute for Focus/Klar installation, Sync, and Default Browser. r=maliu
https://hg.mozilla.org/integration/autoland/rev/b6e018a2e824
Update Leanplum document for Focus/Klar installation, Sync,Default Browser user attribute. r=liuche,maliu
Keywords: checkin-needed
Backed out for Android bustage: package org.mozilla.gecko.fxa does not exist at MmaLeanplumImp.java:19:

https://hg.mozilla.org/integration/autoland/rev/17ce5461467c41cde7d496c11625d8b0adc0d35f
https://hg.mozilla.org/integration/autoland/rev/51aa4e37e2bc14be45c85dc6876806c95a28d814

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b6e018a2e824d9b7493ad3cb642338039aae6e9f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=112681055&repo=autoland

[task 2017-07-07T22:17:06.197138Z] 22:17:06     INFO -  Note: com.google.android.gms.common.internal.DowngradeableSafeParcel accesses a field 'NULL' dynamically
[task 2017-07-07T22:17:06.204967Z] 22:17:06     INFO -        Maybe this is program field 'com.google.android.gms.common.internal.safeparcel.SafeParcelable { java.lang.String NULL; }'
[task 2017-07-07T22:17:06.212511Z] 22:17:06     INFO -        Maybe this is library field 'android.util.JsonToken { android.util.JsonToken NULL; }'
[task 2017-07-07T22:17:06.213075Z] 22:17:06     INFO -        Maybe this is library field 'java.sql.Types { int NULL; }'
[task 2017-07-07T22:17:06.213625Z] 22:17:06     INFO -        Maybe this is library field 'org.json.JSONObject { java.lang.Object NULL; }'
[task 2017-07-07T22:17:06.234514Z] 22:17:06     INFO -  Note: com.google.android.gms.measurement.internal.zzab accesses a declared method 'initialize(android.content.Context)' dynamically
[task 2017-07-07T22:17:06.440426Z] 22:17:06     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:19: error: package org.mozilla.gecko.fxa does not exist
[task 2017-07-07T22:17:06.440513Z] 22:17:06     INFO -  import org.mozilla.gecko.fxa.FirefoxAccounts;
[task 2017-07-07T22:17:06.440548Z] 22:17:06     INFO -                              ^
[task 2017-07-07T22:17:06.456598Z] 22:17:06     INFO -  Note: there were 2 accesses to class members by means of introspection.
[task 2017-07-07T22:17:06.456663Z] 22:17:06     INFO -        You should consider explicitly keeping the mentioned class members
[task 2017-07-07T22:17:06.457048Z] 22:17:06     INFO -        (using '-keep' or '-keepclassmembers').
[task 2017-07-07T22:17:06.457391Z] 22:17:06     INFO -  Ignoring unused library classes...
[task 2017-07-07T22:17:06.458039Z] 22:17:06     INFO -    Original number of library classes: 3633
[task 2017-07-07T22:17:06.458726Z] 22:17:06     INFO -    Final number of library classes:    1101
[task 2017-07-07T22:17:06.458759Z] 22:17:06     INFO -  Obfuscating...
[task 2017-07-07T22:17:06.557771Z] 22:17:06     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:67: error: cannot find symbol
[task 2017-07-07T22:17:06.557858Z] 22:17:06     INFO -          if (MmaDelegate.isDefaultBrowser(activity)) {
[task 2017-07-07T22:17:06.557901Z] 22:17:06     INFO -              ^
[task 2017-07-07T22:17:06.557937Z] 22:17:06     INFO -    symbol:   variable MmaDelegate
[task 2017-07-07T22:17:06.558784Z] 22:17:06     INFO -    location: class MmaLeanplumImp
[task 2017-07-07T22:17:06.558876Z] 22:17:06     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:75: error: cannot find symbol
[task 2017-07-07T22:17:06.558933Z] 22:17:06     INFO -          if (FirefoxAccounts.firefoxAccountsExist(activity)) {
[task 2017-07-07T22:17:06.559203Z] 22:17:06     INFO -              ^
[task 2017-07-07T22:17:06.559277Z] 22:17:06     INFO -    symbol:   variable FirefoxAccounts
[task 2017-07-07T22:17:06.559748Z] 22:17:06     INFO -    location: class MmaLeanplumImp
[task 2017-07-07T22:17:06.574385Z] 22:17:06     INFO -  Note: /home/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/SysInfo.java uses or overrides a deprecated API.
[task 2017-07-07T22:17:06.574601Z] 22:17:06     INFO -  Note: Recompile with -Xlint:deprecation for details.
[task 2017-07-07T22:17:06.575059Z] 22:17:06     INFO -  3 errors
Flags: needinfo?(cnevinchen)
Comment on attachment 8884695 [details]
Bug 1374889 - Gather user attributes before MMA inits.

https://reviewboard.mozilla.org/r/155568/#review160570
Attachment #8884695 - Flags: review?(max) → review+
Flags: needinfo?(cnevinchen)
Keywords: checkin-needed
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 709206baab5a -d 1379551e5fae: rebasing 406302:709206baab5a "Bug 1374889 - Update Leanplum user attribute for Focus/Klar installation, Sync, and Default Browser. r=maliu"
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java
rebasing 406303:8394a6670cbb "Bug 1374889 - Update Leanplum document for Focus/Klar installation, Sync,Default Browser user attribute. r=liuche,maliu"
merging mobile/android/docs/mma.rst
rebasing 406304:dcc8d9e6fd69 "Bug 1374889 - Gather user attributes before MMA inits. r=maliu" (tip)
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 6978122d4626 -d d606c0776761: rebasing 406486:6978122d4626 "Bug 1374889 - Update Leanplum user attribute for Focus/Klar installation, Sync, and Default Browser. r=maliu"
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
rebasing 406487:14b629690d14 "Bug 1374889 - Update Leanplum document for Focus/Klar installation, Sync,Default Browser user attribute. r=liuche,maliu"
rebasing 406488:7d7adafea0e2 "Bug 1374889 - Gather user attributes before MMA inits. r=maliu" (tip)
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c5aca770cd88
Update Leanplum user attribute for Focus/Klar installation, Sync, and Default Browser. r=maliu
https://hg.mozilla.org/integration/autoland/rev/a373612896f5
Update Leanplum document for Focus/Klar installation, Sync,Default Browser user attribute. r=liuche,maliu
https://hg.mozilla.org/integration/autoland/rev/14e9170ccad7
Gather user attributes before MMA inits. r=maliu
Backed out for build bustage on Android 4.0 API15+ opt: "package org.mozilla.gecko.fxa does not exist" at mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:18:

https://hg.mozilla.org/integration/autoland/rev/7035ee09ff47630bad539bd738803ae7de2132b1
https://hg.mozilla.org/integration/autoland/rev/93c33d293da924b3b16a30c128fe3190a1941d19
https://hg.mozilla.org/integration/autoland/rev/2487d4e246f346728c8da8181078369b5dd25d87

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=14e9170ccad702c19849759690aee2b152649ca0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=113276789&repo=autoland

[task 2017-07-11T08:50:33.127462Z] 08:50:33     INFO -  Reading library jar [/home/worker/workspace/build/src/obj-firefox/mobile/android/base/gecko-R.jar]
[task 2017-07-11T08:50:33.315160Z] 08:50:33     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:18: error: package org.mozilla.gecko.fxa does not exist
[task 2017-07-11T08:50:33.315832Z] 08:50:33     INFO -  import org.mozilla.gecko.fxa.FirefoxAccounts;
[task 2017-07-11T08:50:33.316168Z] 08:50:33     INFO -                              ^
[task 2017-07-11T08:50:33.319241Z] 08:50:33     INFO -  Initializing...
[task 2017-07-11T08:50:33.476233Z] 08:50:33     INFO -  Note: /home/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/SysInfo.java uses or overrides a deprecated API.
[task 2017-07-11T08:50:33.476479Z] 08:50:33     INFO -  Note: Recompile with -Xlint:deprecation for details.
[task 2017-07-11T08:50:33.476692Z] 08:50:33     INFO -  1 error
[task 2017-07-11T08:50:33.492610Z] 08:50:33     INFO -  /home/worker/workspace/build/src/config/makefiles/java-build.mk:149: recipe for target 'constants.jar' failed
[task 2017-07-11T08:50:33.492823Z] 08:50:33     INFO -  gmake[5]: *** [constants.jar] Error 1
Flags: needinfo?(cnevinchen)
Flags: needinfo?(cnevinchen)
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45910b8e37de
Update Leanplum user attribute for Focus/Klar installation, Sync, and Default Browser. r=maliu
https://hg.mozilla.org/integration/autoland/rev/b3e29154eac3
Update Leanplum document for Focus/Klar installation, Sync,Default Browser user attribute. r=liuche,maliu
https://hg.mozilla.org/integration/autoland/rev/3791e8357839
Gather user attributes before MMA inits. r=maliu
Flags: needinfo?(max)
You need to log in before you can comment on or make changes to this bug.