1374921 - DOM Event handlers should not use QI from nsIDOMEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Although this does not affect any benchmarks because of event handlers' performance issue, I guess that this may affect quickness of user operation.

https://searchfox.org/mozilla-central/search?q=nsIDOM.*Event%3E.*%5Cn%3F.*do_QueryInterface&case=false&regexp=true&path=
I think that if all of them can use Widget*Event instead, they should use it. Otherwise, I think that mozilla::dom::*Event classes should have |As*Event()| virtual methods like Widget*Event.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Probably yes, though need to be careful with this. What if we want to handle also events named foo when those aren't dispatched using WidgetFooEvent, but generic WidgetEvent. In that case event's message would be the generic one.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I believe the patches landed for bug 1455055 pretty much fix this.  Masayuki-san, do you agree?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #2)
> I believe the patches landed for bug 1455055 pretty much fix this. 
> Masayuki-san, do you agree?

Yes, I do! Really thank you for your work!!