1374930 - Move MediaDecoder::ResourceCallback down the class hierarchy

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

ResourceCallback is used by ChannelMediaResource or FileMediaResource to notify events. We should move the related code down to a sub-class so the code won't be shared by MediaSourceDecoder which doesn't need the events at all.

We will:
1. create ChannelMediaDecoder as the base class that uses channel based resource.
2. ADTSDecoder, AndroidMediaDecoder, FlacDecoder, :MP4Decoder, HLSDecoder, MP3Decoder, OggDecoder, WaveDecoder, and WebMDecoder will inherit ChannelMediaResource instead of MediaResource.
3. move ResourceCallback related code from MediaDecoder into ChannelMediaDecoder.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1374930. P1 - add ChannelMediaDecoder to be the base class which uses channel-based MediaResource.

Review commit: https://reviewboard.mozilla.org/r/151222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151222/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1374930. P2 - add an entry only after FinishDecoderSetup() succeeds.

Review commit: https://reviewboard.mozilla.org/r/151224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151224/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1374930. P3 - move Clone() down to ChannelMediaDecoder for clone is possible only for those use channel-based resource.

Review commit: https://reviewboard.mozilla.org/r/151226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151226/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1374930. P4 - move ResourceCallback to ChannelMediaDecoder.

We also move some methods to protected so they are callable from ChannelMediaDecoder.

Review commit: https://reviewboard.mozilla.org/r/151228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151228/

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8879831 [details]
Bug 1374930. P4 - move ResourceCallback to ChannelMediaDecoder.

https://reviewboard.mozilla.org/r/151228/#review156532

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8879828 [details]
Bug 1374930. P1 - add ChannelMediaDecoder to be the base class which uses channel-based MediaResource.

https://reviewboard.mozilla.org/r/151222/#review156534

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8879829 [details]
Bug 1374930. P2 - add an entry only after FinishDecoderSetup() succeeds.

https://reviewboard.mozilla.org/r/151224/#review156536

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8879830 [details]
Bug 1374930. P3 - move Clone() down to ChannelMediaDecoder for clone is possible only for those use channel-based resource.

https://reviewboard.mozilla.org/r/151226/#review156530

::: commit-message-8a368:1
(Diff revision 1)
> +Bug 1374930. P3 - move Clone() down to ChannelMediaDecoder for clone is possible only for thoese use channel-based resource.

Spelling: thoese

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8879830 [details]
Bug 1374930. P3 - move Clone() down to ChannelMediaDecoder for clone is possible only for those use channel-based resource.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151226/diff/1-2/

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8879831 [details]
Bug 1374930. P4 - move ResourceCallback to ChannelMediaDecoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151228/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e0273470342
P1 - add ChannelMediaDecoder to be the base class which uses channel-based MediaResource. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/6a6012c0da0a
P2 - add an entry only after FinishDecoderSetup() succeeds. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/5627cf7a91fb
P3 - move Clone() down to ChannelMediaDecoder for clone is possible only for those use channel-based resource. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/5b7c5f9f4972
P4 - move ResourceCallback to ChannelMediaDecoder. r=cpearce

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e0273470342
https://hg.mozilla.org/mozilla-central/rev/6a6012c0da0a
https://hg.mozilla.org/mozilla-central/rev/5627cf7a91fb
https://hg.mozilla.org/mozilla-central/rev/5b7c5f9f4972