Closed Bug 1374930 Opened 2 years ago Closed 2 years ago

Move MediaDecoder::ResourceCallback down the class hierarchy

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(4 files)

ResourceCallback is used by ChannelMediaResource or FileMediaResource to notify events. We should move the related code down to a sub-class so the code won't be shared by MediaSourceDecoder which doesn't need the events at all.

We will:
1. create ChannelMediaDecoder as the base class that uses channel based resource.
2. ADTSDecoder, AndroidMediaDecoder, FlacDecoder, :MP4Decoder, HLSDecoder, MP3Decoder, OggDecoder, WaveDecoder, and WebMDecoder will inherit ChannelMediaResource instead of MediaResource.
3. move ResourceCallback related code from MediaDecoder into ChannelMediaDecoder.
Assignee: nobody → jwwang
Blocks: 1373160
Priority: -- → P3
Attachment #8879828 - Flags: review?(cpearce)
Attachment #8879829 - Flags: review?(cpearce)
Attachment #8879830 - Flags: review?(cpearce)
Attachment #8879831 - Flags: review?(cpearce)
Comment on attachment 8879831 [details]
Bug 1374930. P4 - move ResourceCallback to ChannelMediaDecoder.

https://reviewboard.mozilla.org/r/151228/#review156532
Attachment #8879831 - Flags: review?(cpearce) → review+
Comment on attachment 8879828 [details]
Bug 1374930. P1 - add ChannelMediaDecoder to be the base class which uses channel-based MediaResource.

https://reviewboard.mozilla.org/r/151222/#review156534
Attachment #8879828 - Flags: review?(cpearce) → review+
Comment on attachment 8879829 [details]
Bug 1374930. P2 - add an entry only after FinishDecoderSetup() succeeds.

https://reviewboard.mozilla.org/r/151224/#review156536
Attachment #8879829 - Flags: review?(cpearce) → review+
Comment on attachment 8879830 [details]
Bug 1374930. P3 - move Clone() down to ChannelMediaDecoder for clone is possible only for those use channel-based resource.

https://reviewboard.mozilla.org/r/151226/#review156530

::: commit-message-8a368:1
(Diff revision 1)
> +Bug 1374930. P3 - move Clone() down to ChannelMediaDecoder for clone is possible only for thoese use channel-based resource.

Spelling: thoese
Attachment #8879830 - Flags: review?(cpearce) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e0273470342
P1 - add ChannelMediaDecoder to be the base class which uses channel-based MediaResource. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/6a6012c0da0a
P2 - add an entry only after FinishDecoderSetup() succeeds. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/5627cf7a91fb
P3 - move Clone() down to ChannelMediaDecoder for clone is possible only for those use channel-based resource. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/5b7c5f9f4972
P4 - move ResourceCallback to ChannelMediaDecoder. r=cpearce
You need to log in before you can comment on or make changes to this bug.