1374970 - navigator.storage.estimate() returns the group's usage instead of the origin's usage

Status: NEW

(Core :: Storage: Quota Manager, enhancement, P3)

Description

[Ioana Crisan]

Attachment: Test.zip

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170620091714


Steps to reproduce:
1. Open 2 urls belonging to the same group in Nightly 56.0a1
2. Store data into both origins via indexeddb
3. Run the estimate() method in a tab opened for one origin(e.g: origin2)

Expected results:
The estimate() method returns the usage per origin(in this case origin2).
Please see the link to documentation: https://storage.spec.whatwg.org/#dom-storagemanager-estimate

Actual results:
The estimate() method returns the usage per entire group.

Comment 1

[Tom Tung [:tt, :ttung]]

We make estimate() returns group usage because of current QuotaManager's implementation. The QuotaManager bounds site's usage by group limit to prevent from fill disk attack [1]. Since estimate() needs to return quota and usage pair, we choose to return group limit and group usage. 

We've filed the bug 1305665 for removing the group concept from QuotaManager. Once we do that, we'll change estimate() to return origin usage.

[1] http://www.filldisk.com/

Comment 2

[Francis Lee [:frlee]]

this is by design for current project scope. improvement could be considered for post-57.

Comment 3

[Jens Stutte [:jstutte]]

:janv, as we are far post-57, is this (and bug 1305665) something to consider in our QuotaManager refactorings?

Comment 4

[Jan Varga [:janv]]

Well, this is not directly related to the layout on disk which is the main subject of QM v4. The main bug for removing groups is bug 1305665 and it will be addressed in some other refactoring or rather architecture change. Anyway, I feel that QM v4 can help in this regard because it will enable implementation of buckets which can have different quota limits and eviction policies. So for example, the group limit might stay for the default bucket but other buckets wouldn't be limited by the group limit anymore. A further investigatation and discussion is needed.

Comment 5

[Jari Jalkanen [:jari]]

We should comply with the spec and return origin's usage instead of the group's usage.