1374977 - Include the version details in the log

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Whilst running tests against Sauce Labs, it became clear that there's no way to determine the version of geckodriver in use. This level of detail could be useful when troubleshooting issues using Selenium as a service. Could we add the version details when starting geckodriver? Sauce Labs do provide an automator.log file, which contains the geckodriver log contents, so we see entries such as:

1498037999220	geckodriver	INFO	Listening on 127.0.0.1:46473
1498037999889	geckodriver::marionette	INFO	Starting browser \\?\D:\Program Files\Firefox 54\firefox.exe with args ["-marionette"]
1498038000363	Marionette	WARN	Deprecated preference marionette.defaultPrefs.enabled detected, please use marionette.enabled
1498038001957	Marionette	INFO	Listening on port 49757

Comment 1

[Andreas Tolfsen ❲:ato❳]

We have dismissed requests to include the geckodriver version in in the
return capabilities before, but there should not be any harm in logging
the version number.

Comment 2

[Andreas Tolfsen ❲:ato❳]

I have laid the groundwork for this in
https://bugzilla.mozilla.org/show_bug.cgi?id=1375207.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1374977 - Log geckodriver version on startup;

Review commit: https://reviewboard.mozilla.org/r/152196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152196/

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8880855 [details]
Bug 1374977 - Log geckodriver version on startup;

https://reviewboard.mozilla.org/r/152196/#review157260

::: testing/geckodriver/src/main.rs:50
(Diff revision 1)
>  use logging::LogLevel;
>  use marionette::{MarionetteHandler, MarionetteSettings, extension_routes};
>  
>  include!(concat!(env!("OUT_DIR"), "/build-info.rs"));
>  
> +type ProgramResult = std::result::Result<(), (ExitCode, String)>;

Not for this review, but https://crates.io/crates/exitcode exists.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8880855 [details]
Bug 1374977 - Log geckodriver version on startup;

https://reviewboard.mozilla.org/r/152196/#review157260

Thanks!

> Not for this review, but https://crates.io/crates/exitcode exists.

Yay for microcrates?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eca8198fea5
Log geckodriver version on startup; r=jgraham

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6eca8198fea5