Closed Bug 1375024 Opened 7 years ago Closed 7 years ago

Icons overlapping RTL text in onboarding tour

Categories

(Firefox :: Tours, defect, P1)

Product:
Firefox
Component:
Tours
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed

People

(Reporter: khaled, Assigned: tomer)

References

Details

(Keywords: regression, rtl, Whiteboard: [photon-onboarding])

Attachments

(2 files)

Screenshot
225.28 KB, image/png
Details
Bug 1375024 - Icons overlapping RTL text in onboarding tour
59 bytes, text/x-review-board-request
rexboy
: review+
mossop
: review+
Details
Attached image Screenshot —
After updating Nightly today, the icons in the onboarding tour are overlapping the Arabic text. There was no overlap before the update.
Attachment #8879956 - Attachment description: لقطة شاشة من 2017-06-21 15-29-16.png → Screenshot
Keywords: regression, regressionwindow-wanted
Whiteboard: [photon-onboarding][triage]
Priority: -- → P1
Summary: Icons overlapping Arabic text in onboarding tour → Icons overlapping RTL text in onboarding tour
Steps to reproduce: Open RTL build of Firefox, navigate to about:newtab, click the fox icon, notice the text overlapping the icons. For mozregression, I've used the en-US build then manually changed <body dir="ltr"> to rtl on about:newtab using the inspector tool. 29:03.54 INFO: Last good revision: ea7907038c5f5d77803ef1d85f59918836cee54f 29:03.54 INFO: First bad revision: 49d4a1aa666a1478a4271390245d42308b5a30b3 29:03.54 INFO: Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ea7907038c5f5d77803ef1d85f59918836cee54f&tochange=49d4a1aa666a1478a4271390245d42308b5a30b3
Blocks: 1370459
status-firefox54: --- → unaffected
status-firefox55: --- → unaffected
status-firefox56: --- → affected
status-firefox-esr52: --- → unaffected
Keywords: regressionwindow-wanted → rtl
So looks like the bug comes from this rule: https://hg.mozilla.org/integration/autoland/rev/49d4a1aa666a#l2.83 which should be updated to match https://hg.mozilla.org/integration/autoland/rev/49d4a1aa666a#l2.76
Assignee: nobody → tomer.moz.bugs
Attachment #8880062 - Flags: review?(gijskruitbosch+bugs) → review?(fliu)
Comment on attachment 8880062 [details] Bug 1375024 - Icons overlapping RTL text in onboarding tour https://reviewboard.mozilla.org/r/151384/#review156564 Help on this since Fischer is working on notification features. It should be a leftover we missed on polishing. Thanks for fixing it. The patch looks good to me and tested ok.
Attachment #8880062 - Flags: review+
Keywords: checkin-needed
Flags: qe-verify+
QA Contact: jwilliams
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Sorry for didn't get the progress right. Mossop may you help on this reviewing?
Comment on attachment 8880062 [details] Bug 1375024 - Icons overlapping RTL text in onboarding tour https://reviewboard.mozilla.org/r/151384/#review156898
Attachment #8880062 - Flags: review?(dtownsend) → review+
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a1b6cb55ce3b Icons overlapping RTL text in onboarding tour r=mossop,rexboy
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a1b6cb55ce3b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Confirmed fixed on latest Nightly 2017-06-27.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: