1375114 - Text appear selected when switching from display:none to display:block

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement, P3)

Description

[flyingrub]

The text of the subcategory is selected when we switch display: none to display: block. We change it with a css rules if the parent has a special class.

What we tried to fix it :
* Add preventDefault in the click listener
* Wrap the classList.add in a setTimeout()
* If we comment the display none in css no text is selected when adding the class

Current Fix : document.getSelection().empty(); just after the add of the class.

Bug introduced here : https://bugzilla.mozilla.org/show_bug.cgi?id=1370513

Comment 1

[flyingrub]

My build is rather up-to-date with central and I forgot to mention that this bug is located in about:telemetry.
The source file of about:telemetry are located there : toolkit/content/aboutTelemetry.*

Comment 2

[Mats Palmgren (inactive)]

What are the steps to reproduce the problem?

Comment 3

[flyingrub]

Steps to reproduce : 
1) Build firefox with this patch : https://reviewboard.mozilla.org/r/146220/
3) Look for the bug number 1375114 and comment the line below
2) Go to about:telemetry and click on the Environment Data section
The text of the subsection should appear selected.

Comment 4

[Mats Palmgren (inactive)]

Attachment: fix?

I haven't debugged in detail what happens during the event
handling here but I'm guessing that when a click occurs on
a section header the selection is collapsed to some node there.
Then aboutTelemetry.js handles the event by inserting
new content (the subsections) which somehow ends up inside
that collapsed selection.  That might actually be the correct
handling per spec depending on the exact details.

Anyway, there's a simpler way to workaround for this than
manually resetting the selection from script: just disable
selection entirely in the navigation panel.
That's what you want, right?

Comment 5

[flyingrub]

Did you tried this fix?
If i remember correctly I already tried to add -moz-user-select: none but it didn't prevent the selection. :/

Comment 6

[Mats Palmgren (inactive)]

Yeah, it works for me in a local build on Linux.

Comment 7

[flyingrub]

My laptop just died so I don't have any way to test your patch...

Comment 8

[flyingrub]

:chutten could you take a look ?

Comment 9

[Chris H-C :chutten]

I'm in transit due to Quantum Launch, but I'm hopeful about this fix. I'll leave the ni? to remind me to try this tomorrow, unless someone else can get to it first...?

Comment 10

[Chris H-C :chutten]

Comment on attachment 8924379 [details] [diff] [review]
fix?

Review of attachment 8924379 [details] [diff] [review]:
-----------------------------------------------------------------

This seems to take care of it in my build

Comment 11

[Chris H-C :chutten]

It seems as though :flyingrub is busy elsewhere. :mats, shall we set this to checkin?

Comment 12

[Mats Palmgren (inactive)]

Sounds good to me.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56f0c8ff41a0
Disable selection entirely in the #categories navigation panel. r=chutten

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/56f0c8ff41a0

Comment 15

[flyingrub]

Just to say I tested it without moz-user-select: none; and it does not select the text anymore.