Closed
Bug 1375125
Opened 4 years ago
Closed 4 years ago
Remove nsILocalFile
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: emk, Assigned: emk)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
It is merged into nsIFile and is left only for compatibility.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 4•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b0c63a3e42623ed38f87bba156db0e19f31b6ef Windows buildbot builds and jetpack-package-clipboard are known permafail.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
|
||
Comment 5•4 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894042 [details] Bug 1375125 - Stop using nsILocalFile in the tree. https://reviewboard.mozilla.org/r/165140/#review170546 r=me assuming this was done by something like `perl -p -i -e 's/nsILocalFile/nsIFile/' ...`
Attachment #8894042 -
Flags: review?(nfroyd) → review+
|
|
||
Comment 6•4 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894043 [details] Bug 1375125 - Fix errors caused by mechanical replacement. https://reviewboard.mozilla.org/r/165142/#review170548 ::: addon-sdk/source/lib/sdk/io/fs.js:21 (Diff revision 1) > > const { ns } = require("../core/namespace"); > const { Class } = require("../core/heritage"); > > > -const nsIFile = CC("@mozilla.org/file/local;1", "nsIFile", > +const LocalFile = CC("@mozilla.org/file/local;1", "nsIFile", This change isn't strictly necessary, is it? It's just making things more consistent?
Attachment #8894043 -
Flags: review?(nfroyd) → review+
|
|
||
Comment 7•4 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894044 [details] Bug 1375125 - Remove nsILocalFile. https://reviewboard.mozilla.org/r/165144/#review170550
Attachment #8894044 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 8•4 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8894043 [details] Bug 1375125 - Fix errors caused by mechanical replacement. https://reviewboard.mozilla.org/r/165142/#review170548 > This change isn't strictly necessary, is it? It's just making things more consistent? This file has > var nsIFile = accessor(); later, so it fails with redeclaration of const without this change.
|
||
Comment 9•4 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 1ac5df95d749 -d d9bef5f3594d: rebasing 411788:1ac5df95d749 "Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj" other [source] changed security/manager/tools/makeCNNICHashes.js which local [dest] deleted use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u merging browser/base/content/browser.js merging browser/components/places/content/places.js merging toolkit/content/widgets/preferences.xml unresolved conflicts (see hg resolve, then hg rebase --continue)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 13•4 years ago
|
||
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/autoland/rev/f904bc721e7d Stop using nsILocalFile in the tree. r=froydnj https://hg.mozilla.org/integration/autoland/rev/56b1b043078b Fix errors caused by mechanical replacement. r=froydnj https://hg.mozilla.org/integration/autoland/rev/b34cf908546b Remove nsILocalFile. r=froydnj
|
|
||
Comment 14•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f904bc721e7d https://hg.mozilla.org/mozilla-central/rev/56b1b043078b https://hg.mozilla.org/mozilla-central/rev/b34cf908546b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•