1375125 - Remove nsILocalFile

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Masatoshi Kimura [:emk]]

It is merged into nsIFile and is left only for compatibility.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1375125 - Stop using nsILocalFile in the tree.

This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

Review commit: https://reviewboard.mozilla.org/r/165140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165140/

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1375125 - Fix errors caused by mechanical replacement.

Review commit: https://reviewboard.mozilla.org/r/165142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165142/

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Bug 1375125 - Remove nsILocalFile.

Review commit: https://reviewboard.mozilla.org/r/165144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165144/

Comment 4

[Masatoshi Kimura [:emk]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b0c63a3e42623ed38f87bba156db0e19f31b6ef
Windows buildbot builds and jetpack-package-clipboard are known permafail.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8894042 [details]
Bug 1375125 - Stop using nsILocalFile in the tree.

https://reviewboard.mozilla.org/r/165140/#review170546

r=me assuming this was done by something like `perl -p -i -e 's/nsILocalFile/nsIFile/' ...`

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8894043 [details]
Bug 1375125 - Fix errors caused by mechanical replacement.

https://reviewboard.mozilla.org/r/165142/#review170548

::: addon-sdk/source/lib/sdk/io/fs.js:21
(Diff revision 1)
>  
>  const { ns } = require("../core/namespace");
>  const { Class } = require("../core/heritage");
>  
>  
> -const nsIFile = CC("@mozilla.org/file/local;1", "nsIFile",
> +const LocalFile = CC("@mozilla.org/file/local;1", "nsIFile",

This change isn't strictly necessary, is it?  It's just making things more consistent?

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8894044 [details]
Bug 1375125 - Remove nsILocalFile.

https://reviewboard.mozilla.org/r/165144/#review170550

Comment 8

[Masatoshi Kimura [:emk]]

Comment on attachment 8894043 [details]
Bug 1375125 - Fix errors caused by mechanical replacement.

https://reviewboard.mozilla.org/r/165142/#review170548

> This change isn't strictly necessary, is it?  It's just making things more consistent?

This file has
> var nsIFile = accessor();

later, so it fails with redeclaration of const without this change.

Comment 9

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 1ac5df95d749 -d d9bef5f3594d: rebasing 411788:1ac5df95d749 "Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj"
other [source] changed security/manager/tools/makeCNNICHashes.js which local [dest] deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u
merging browser/base/content/browser.js
merging browser/components/places/content/places.js
merging toolkit/content/widgets/preferences.xml
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 10

[Masatoshi Kimura [:emk]]

Comment on attachment 8894042 [details]
Bug 1375125 - Stop using nsILocalFile in the tree.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165140/diff/1-2/

Comment 11

[Masatoshi Kimura [:emk]]

Comment on attachment 8894043 [details]
Bug 1375125 - Fix errors caused by mechanical replacement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165142/diff/1-2/

Comment 12

[Masatoshi Kimura [:emk]]

Comment on attachment 8894044 [details]
Bug 1375125 - Remove nsILocalFile.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165144/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f904bc721e7d
Stop using nsILocalFile in the tree. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/56b1b043078b
Fix errors caused by mechanical replacement. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/b34cf908546b
Remove nsILocalFile. r=froydnj

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f904bc721e7d
https://hg.mozilla.org/mozilla-central/rev/56b1b043078b
https://hg.mozilla.org/mozilla-central/rev/b34cf908546b