1375133 - Remove unnecessary imports of btoa and atob in services/ code

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, enhancement)

Description

[Andrew McCreight [:mccr8]]

There are a few places in services/ tests that import btoa and atob, but this is not necessary, because those are both defined on the XPCShell global (by glob_functions in XPCShellImpl.cpp). It sounds like it didn't work at some point on B2G (see bug 937114) but that isn't relevant any more. I want to fix this because the way these properties are imported will break with shared JSM globals.

Comment 1

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ebdd0c7e2b77efdc53e475953af7d0701d71e61

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1375133 - Remove unnecessary imports of btoa and atob in services/ code.

There are a few places in services/ tests that import btoa and atob,
but this is not necessary, because those are both defined on the
XPCShell global (by glob_functions in XPCShellImpl.cpp). It sounds
like it didn't work at some point on B2G (see bug 937114) but that
isn't relevant any more. I want to fix this because the way these
properties are imported will break with shared JSM globals.

Review commit: https://reviewboard.mozilla.org/r/151478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151478/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8880106 [details]
Bug 1375133 - Remove unnecessary imports of btoa and atob in services/ code.

https://reviewboard.mozilla.org/r/151478/#review156512

rs=me!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf00db12a779
Remove unnecessary imports of btoa and atob in services/ code. r=markh

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bf00db12a779