If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove unnecessary imports of btoa and atob in services/ code

RESOLVED FIXED in Firefox 56

Status

Cloud Services
Firefox: Common
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
There are a few places in services/ tests that import btoa and atob, but this is not necessary, because those are both defined on the XPCShell global (by glob_functions in XPCShellImpl.cpp). It sounds like it didn't work at some point on B2G (see bug 937114) but that isn't relevant any more. I want to fix this because the way these properties are imported will break with shared JSM globals.
(Assignee)

Comment 1

3 months ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ebdd0c7e2b77efdc53e475953af7d0701d71e61
Comment hidden (mozreview-request)

Comment 3

3 months ago
mozreview-review
Comment on attachment 8880106 [details]
Bug 1375133 - Remove unnecessary imports of btoa and atob in services/ code.

https://reviewboard.mozilla.org/r/151478/#review156512

rs=me!
Attachment #8880106 - Flags: review?(markh) → review+

Comment 4

3 months ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf00db12a779
Remove unnecessary imports of btoa and atob in services/ code. r=markh

Comment 5

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bf00db12a779
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.