1375141 - Crash in java.lang.NullPointerException: uriString at android.net.Uri$StringUri.<init>(Uri.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Julien Cristau [:jcristau]]

This bug was filed from the Socorro interface and is 
report bp-cbd219cf-953a-4511-bc4e-10ff60170620.
=============================================================

There's a few of those in the last few days on nightly:

java.lang.NullPointerException: uriString
	at android.net.Uri$StringUri.<init>(Uri.java:475)
	at android.net.Uri$StringUri.<init>(Uri.java:465)
	at android.net.Uri.parse(Uri.java:437)
	at org.mozilla.gecko.customtabs.CustomTabsActivity.onOpenInClicked(CustomTabsActivity.java:416)
	at org.mozilla.gecko.customtabs.CustomTabsActivity.onOptionsItemSelected(CustomTabsActivity.java:254)
	at org.mozilla.gecko.customtabs.CustomTabsActivity.onMenuItemClick(CustomTabsActivity.java:225)
	at org.mozilla.gecko.customtabs.CustomTabsActivity$4.onMenuItemClick(CustomTabsActivity.java:310)
	at org.mozilla.gecko.widget.GeckoPopupMenu.onMenuItemClick(GeckoPopupMenu.java:163)
	at org.mozilla.gecko.menu.GeckoMenu.handleMenuItemClick(GeckoMenu.java:662)
	at org.mozilla.gecko.menu.GeckoMenu.onItemClick(GeckoMenu.java:638)
	at android.widget.AdapterView.performItemClick(AdapterView.java:300)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1143)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:3048)
	at android.widget.AbsListView$3.run(AbsListView.java:3837)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:211)
	at android.app.ActivityThread.main(ActivityThread.java:5335)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1016)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811)

Comment 1

[Julien Cristau [:jcristau]]

Expanding the date range, it seems this isn't all that new after all.

Comment 2

[[:philipp]]

[Tracking Requested - why for this release]:
this signature is spiking up during the 57.0b cycle and may be related to bug 1356346.
on 57.0b9 it's the #4 fennec top crash accounting for 3.1% of all crashes.

Comment 3

[Julien Cristau [:jcristau]]

Max, Wesly, this crash is getting worse in beta57, see comment 2.  Can you find someone to work on it?

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1375141-1.0-Check-for-null-URI-when-sending-view.patch

We should always check for null-URIs before sending out view intents.

We should also check how that can be the case, are we missing some onLocationChange events?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff3b69d3b045
[1.0] Check for null-URI when sending view intent from Open-in menu item. r=snorp

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ff3b69d3b045

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 8

[Eugen Sawin [:esawin]]

Comment on attachment 8920196 [details] [diff] [review]
0001-Bug-1375141-1.0-Check-for-null-URI-when-sending-view.patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1356346
[User impact if declined]: Crash when trying to use Open-In feature in some (yet unknown) cases in custom tabs
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: STR not available
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: The change only prevents a null-reference access crash
[String changes made/needed]: None

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8920196 [details] [diff] [review]
0001-Bug-1375141-1.0-Check-for-null-URI-when-sending-view.patch

Crash fix, Beta57+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8d7197e77da1

Comment 11

[Calixte Denizet (:calixte)]

The crashes are still there in 57.0b11 & 57.0b13.
By the way, the volume is strongly lower than in 57.0b9 (see[1]).

[1] http://bit.ly/2zdn87W

Comment 12

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1375141-2.0-Check-for-null-URI-when-attaching-pe.patch

Same signature, slightly different crash stack.
Again, we need to make sure that we don't parse a null-URI.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bbcbeb797d3
[2.0] Check for null-URI when attaching pending intent data. r=snorp

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8bbcbeb797d3

Comment 15

[Eugen Sawin [:esawin]]

Comment on attachment 8925518 [details] [diff] [review]
0001-Bug-1375141-2.0-Check-for-null-URI-when-attaching-pe.patch

See comment 8.

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 8925518 [details] [diff] [review]
0001-Bug-1375141-2.0-Check-for-null-URI-when-attaching-pe.patch

null check, for 57 rc2

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/a9f258850178

Comment 18

[u549602]

Could not reproduce any crashes in our test day for 57.0 Build 2. 
We tried different scenarios that involve custom tabs on different devices and still couldn't reproduce any crashes.
I'm leaving this issue still open so that we get more related crash stats and decide afterwards.