make llvm-config check also check ~/.mozbuild/ location chosen by `mach bootstrap`

RESOLVED FIXED in Firefox 56

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: froydnj, Unassigned)

Tracking

Trunk
mozilla56
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
We need to do this so most users will not have to add anything special to their mozconfig once they have run `mach bootstrap`: the build system will detect the installed bits automatically.
(Reporter)

Comment 1

a year ago
Created attachment 8880123 [details] [diff] [review]
check for llvm-config where `mach bootstrap` would install it

For ease of use, we want to make checks for llvm-config automatically
examine the directory where `mach bootstrap` would install things, so
users don't necessarily have to have a mozconfig when building stylo.
Since the computation of this value is non-trivial, we pull out the
whole list of possible names for llvm-config into a @depends function,
and insert the computed value into that list when necessary.
Attachment #8880123 - Flags: review?(giles)
(Reporter)

Updated

a year ago
Blocks: 1310852
Comment on attachment 8880123 [details] [diff] [review]
check for llvm-config where `mach bootstrap` would install it

Review of attachment 8880123 [details] [diff] [review]:
-----------------------------------------------------------------

I was just wondering about this!
Attachment #8880123 - Flags: review?(giles) → review+

Comment 3

a year ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a99f0444e21
check for llvm-config where `mach bootstrap` would install it; r=rillian

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7a99f0444e21
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.