1375188 - Don't import TextEncoder from osfile.jsm in CoverageUtils.jsm

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Andrew McCreight [:mccr8]]

CoverageUtils.jsm contains this code:
  const {TextEncoder, OS} = Cu.import("resource://gre/modules/osfile.jsm", ccov_scope);
  this._encoder = new TextEncoder();

However, the WebIDL interface for TextEncoder has Exposed=System, so TextEncoder should be available on the JSM global. (This code was added in Dec 2015, and TextEncoder has had System since at least Nov 2014, so it was probably unnecessary the entire time.)


I'm making this change because this style of importing globals from JSMs will break with bug 1186409.

I can also revert the part of bug 1348103 that moved the initialization of _encoder to later.

I retriggered the XPCShell suite that contains the test that bug 1348103 was fixing and it looks okay: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b68186f6eaeba9357919d205c9498582a984fce1

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1375188 - Don't import TextEncoder from osfile.jsm in CoverageUtils.jsm.

This import is unnecessary, because the WebIDL interface for
TextEncoder has Exposed=System, so it is available on the JSM
global. I can revert some of the changes from bug 1348103 at the same
time.

I need to remove this import, because it will break with shared JSM
globals.

Review commit: https://reviewboard.mozilla.org/r/151416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151416/

Comment 2

[Greg Mierzwinski [:sparky]]

Thanks for taking care of this :mccr8!

Comment 3

[:Gijs (he/him)]

Comment on attachment 8880072 [details]
Bug 1375188 - Don't import TextEncoder from osfile.jsm in CoverageUtils.jsm.

https://reviewboard.mozilla.org/r/151416/#review156444

rs=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6399592c5aca
Don't import TextEncoder from osfile.jsm in CoverageUtils.jsm. r=Gijs

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6399592c5aca