Closed Bug 1375315 Opened 3 years ago Closed 3 years ago
stylo: List bullet restyling misses some cases
59 bytes, text/x-review-board-request
The patches in bug 1364871 missed a bunch of cases to do with list bullets on anonymous blocks of various sorts. Some of these are stupid (e.g. <select style="display: list-item"> creates _three_ bullet frames, and with "list-style-position: inside" will actually show two of them) but a few (columns and non-visible overflow on list items) really do need to be fixed. Need to clean this up before I try to make first-letter/first-line work, because I want to use a pretty similar mechanism for those. Luckily, Emilio suggested a perfectly good fix for this.
Comment on attachment 8880217 [details] Bug 1375315. Make sure to update block pseudo-element styles on various anonymous blocks. https://reviewboard.mozilla.org/r/151578/#review156612 ::: layout/reftests/bugs/1375315-7.html:9 (Diff revision 1) > + var height = document.body.offsetHeight; // Flush layout > + document.querySelector("legend").style.color = "green"; > + } > +</script> > +<fieldset> > + <legend style="display: list-item; color: red">Bullet should be green</legend> Well, the reftests aren't that nasty as I thought :)
Attachment #8880217 - Flags: review?(emilio+bugs) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 9322edd5db29 -d c802a2225e3e: rebasing 403439:9322edd5db29 "Bug 1375315. Make sure to update block pseudo-element styles on various anonymous blocks. r=emilio" (tip) merging layout/base/ServoRestyleManager.cpp merging layout/generic/nsFrame.cpp merging layout/reftests/bugs/reftest.list warning: conflicts while merging layout/base/ServoRestyleManager.cpp! (edit, then use 'hg resolve --mark') warning: conflicts while merging layout/generic/nsFrame.cpp! (edit, then use 'hg resolve --mark') warning: conflicts while merging layout/reftests/bugs/reftest.list! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/64a65ce29ca3 Make sure to update block pseudo-element styles on various anonymous blocks. r=emilio
You need to log in before you can comment on or make changes to this bug.