Closed Bug 1375340 Opened 7 years ago Closed 7 years ago

Thunderbird 52.2.1 failing balrog submission

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Unassigned)

References

Details

Attachments

(1 file)

All platforms, eg mac:

Balrog request to https://aus4-admin.mozilla.org/api/releases/Thunderbird-52.2.1-build1/builds/Darwin_x86_64-gcc3-u-i386-x86_64/en-US
Data sent: {'data': '{"buildID": "20170621143358", "appVersion": "52.2.1", "displayVersion": "52.2.1", "partials": [{"hashValue": "8fc42371e8e61f6029cbc4f95d9d6a4360b0fc8c7dd20b6d6fea64632850496b42f0582ec500036af63bf708cc64579b25781a7b0bd61d296e409da9b0865f63", "from": "Thunderbird-52.2.0-build1", "filesize": "3417246"}, {"hashValue": "e71a1b819fe17cc926cd81663c7d2479c240715cf6463315f74d5b7fcba520e1070409c3d5d0524d6fc4f942c56d5b92d483362b58728dd807b669249506dc66", "from": "Thunderbird-45.8.0-build1", "filesize": "63946226"}, {"hashValue": "8c90bc2f4d818a61fc9e9044df2a1e8fecd62fb511b5bbf91db95f2ae9e192475965800fedaa78184fad619d9dc6c7c22eb3c7d58cab6c3f9bb2f6fe52bf82c9", "from": "Thunderbird-52.1.1-build1", "filesize": "11334141"}], "platformVersion": "52.2.1", "completes": [{"hashValue": "1deba8ebdc1885ac32265a00e53b355881966c0fb4ee6034b3b01b27e4d24b6e2d035f39f14b558aec57fb738b330fa7646e575dff9761bd85fad3f70c1b45c0", "from": "*", "filesize": "76751366"}]}', 'product': u'Thunderbird', 'hashFunction': u'sha512', 'schema_version': '4'}
"PUT /api/releases/Thunderbird-52.2.1-build1/builds/Darwin_x86_64-gcc3-u-i386-x86_64/en-US HTTP/1.1" 400 135
Caught HTTPError: {
  "detail": "schema_version: u'4' is not of type 'integer'", 
  "status": 400, 
  "title": "Bad Request", 
  "type": "about:blank"
}

We deployed Balrog today so could be fallout from that.
Looks like Nightly jobs (aka Firefox m-c using funsize) send 'schema_version': 4, so they'll be OK. I suspect Firefox releases are also affected; likely fallout from bug 1336452.
Blocks: 1374991, 1336452
I tested this on the mac slave which failed the release build, and the data was submitted OK. FYI, did try staging first, but it was returning a 200 and data which couldn't be json decoded, instead of prod's 404.

"GET /releases/Thunderbird-52.2.1-build1 HTTP/1.1" 200 2703
REQUEST STATS: {"url": "https://balrog-admin.stage.mozaws.net/releases/Thunderbird-52.2.1-build1", "timestamp": 1498103916.858527, "method": "GET", "elapsed_secs": 0.4714009761810303, "status_code": 200}
Traceback (most recent call last):
  File "/builds/slave/tb-rel-c-esr52-m64_bld-0000000/tools/scripts/updates/balrog-submitter.py", line 106, in <module>
    **updateKwargs)
  File "/builds/slave/tb-rel-c-esr52-m64_bld-0000000/tools/lib/python/balrog/submitter/cli.py", line 481, in run
    return ReleaseSubmitterBase.run(self, *args, schemaVersion=4, **kwargs)
...
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 360, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 378, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
Might have been trying to provide history.

For Firefox, I think we'll pick the tools patch when we regenerate the funsize docker image, and jobs like http://mozilla-release-logs.s3.amazonaws.com/mozilla-beta/firefox-55.0b3/build1/%5Bfunsize%5D_Publish_to_Balrog_linux64_chunk_10_for_54.0-linux64-6IU4LrnGR1uADTbAW02utw-0 will be OK. The 'updates' job is OK already.
Comment on attachment 8880225 [details] [diff] [review]
[tools] Stop converting the int to a string for releases

Review of attachment 8880225 [details] [diff] [review]:
-----------------------------------------------------------------

I can't quite figure out why we would've json.dump'ed() this in the first...
Attachment #8880225 - Flags: review?(bhearsum) → review+
Comment on attachment 8880225 [details] [diff] [review]
[tools] Stop converting the int to a string for releases

Thanks for the fix for this, Nick. Landed as https://hg.mozilla.org/build/tools/rev/c92e90877846b413e88a1cd1401c26eaf9481041
Attachment #8880225 - Flags: checked-in+
Updated the checkouts on the balrog scriptworker machines. I'm not certain they need it, since this is release-only, but better safe than sorry. Rail, can you update the funsize images?
Flags: needinfo?(rail)
Done.
Flags: needinfo?(rail)
Retriggers succeeded.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: