1375440 - Crash in nsDocumentViewer::~nsDocumentViewer

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is 
report bp-727fac35-1978-483d-bf5a-31d390170622.
=============================================================
Crashing Thread (0)
Frame 	Module 	Signature 	Source
0 	xul.dll 	nsDocumentViewer::~nsDocumentViewer() 	layout/base/nsDocumentViewer.cpp:602
1 	xul.dll 	nsDocumentViewer::Release() 	layout/base/nsDocumentViewer.cpp:567
2 	xul.dll 	nsCOMPtr_base::~nsCOMPtr_base() 	obj-firefox/dist/include/nsCOMPtr.h:294
3 	xul.dll 	mozilla::SegmentedVector<nsCOMPtr<nsISupports>, 4096, mozilla::MallocAllocPolicy>::PopLastN(unsigned int) 	obj-firefox/dist/include/mozilla/SegmentedVector.h:265
4 	xul.dll 	mozilla::dom::DeferredFinalizerImpl<nsISupports>::DeferredFinalize(unsigned int, void*) 	obj-firefox/dist/include/mozilla/dom/BindingUtils.h:2805
5 	xul.dll 	mozilla::IncrementalFinalizeRunnable::ReleaseNow(bool) 	xpcom/base/CycleCollectedJSRuntime.cpp:1322
6 	xul.dll 	mozilla::IncrementalFinalizeRunnable::Run() 	xpcom/base/CycleCollectedJSRuntime.cpp:1356
7 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp:1418
8 	xul.dll 	mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp:96
9 	xul.dll 	mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp:301
10 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc:231
11 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc:211
12 	xul.dll 	nsBaseAppShell::Run() 	widget/nsBaseAppShell.cpp:156
13 	xul.dll 	nsAppShell::Run() 	widget/windows/nsAppShell.cpp:271
14 	xul.dll 	XRE_RunAppShell() 	toolkit/xre/nsEmbedFunctions.cpp:896
15 	xul.dll 	mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp:269
16 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc:231
17 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc:211
18 	xul.dll 	XRE_InitChildProcess(int, char** const, XREChildData const*) 	toolkit/xre/nsEmbedFunctions.cpp:712
19 	xul.dll 	mozilla::BootstrapImpl::XRE_InitChildProcess(int, char** const, XREChildData const*) 	toolkit/xre/Bootstrap.cpp:65
20 	firefox.exe 	content_process_main(mozilla::Bootstrap*, int, char** const) 	ipc/contentproc/plugin-container.cpp:64
21 	firefox.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp:115
22 	firefox.exe 	__scrt_common_main_seh 	f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:253
23 	kernel32.dll 	BaseThreadInitThunk 	
24 	ntdll.dll 	__RtlUserThreadStart 	
25 	ntdll.dll 	_RtlUserThreadStart

these reports are increasing in number after the start of the 55.0b cycle. currently the crash reports only come from windows clients and mostly in the content process. the crashes happen with MOZ_RELEASE_ASSERT(mDestroyWasFull) that got added in bug 1354933.

Comment 1

[Timothy Nikkel (:tnikkel)]

I've requested beta approval to back out these diagnostic asserts from beta.

Comment 2

[Timothy Nikkel (:tnikkel)]

Removed this assert from 55.

Comment 3

[Astley Chen (inactive)]

Per bug 1354933 comment 37, the assertion code was removed from 55 so it should not happen in the following 55.0b5 build.