1375456 - unable to run mach talos-test -a quantum_pageload_X due to nonlocal network connection

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we should ensure that we disable this for quantum or figure out how to add an exception to the proxy.

Comment 1

[Robert Wood [:rwood]]

How did this change? I was disabling it for the quantum-pageload test.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I probably re-enabled it for all talos- lets figure out how to disable it for quantum specifically:
https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/ffsetup.py?q=path%3Affsetup.py&redirect_type=single#72

that makes sense as to why this was not set!

Comment 3

[Robert Wood [:rwood]]

Hmmm yeah it's being set here in ttest, just for quantum-pageload but it must be overwritten somewhere else:

http://searchfox.org/mozilla-central/source/testing/talos/talos/ttest.py#110

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

possibly this is during the profile warmup where the problem is, that is where I added the env var in order to try to fix the webext stuff, despite marionette not working.

Comment 5

[Robert Wood [:rwood]]

Interesting, I can't reproduce this. I pulled the latest central onto my local Win 10 test box, did a build, and the talos quantum-pageload-e10s tests ran fine (mach talos-test --suite quantum-pageload-e10s). All the mitmproxy pages are loaded (and results reported).

Comment 6

[Robert Wood [:rwood]]

Oh wait I just noticed you use -a to run each test separate, ok right. Did you add the --mitmproxy argument on the command line also?

Comment 7

[Robert Wood [:rwood]]

i.e. this works on my Win10 box:

mach talos-test -a quantum_pageload_google --mitmproxy mitmproxy-recording-google.mp

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

where would you get mitmproxy-recording-google.mp ?

Comment 9

[Robert Wood [:rwood]]

The file itself will be downloaded automatically (inside the playback archive). This same command line is automatically set in in the talos.json talos_optios for the quantum-pageload-e10s test. Maybe I should add code to have talos grab that if someone tries to run one of the quantum_pageload_* tests just via -a and not expect it on the command line.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

+1 for that

Comment 11

[Robert Wood [:rwood]]

Attachment: Bug 1375456 - Fix running talos quantum_pageload_* tests locally with -activeTests;

Review commit: https://reviewboard.mozilla.org/r/152498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152498/

Comment 12

[Robert Wood [:rwood]]

Comment on attachment 8881297 [details]
Bug 1375456 - Fix running talos quantum_pageload_* tests locally with -activeTests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152498/diff/1-2/

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8881297 [details]
Bug 1375456 - Fix running talos quantum_pageload_* tests locally with -activeTests;

https://reviewboard.mozilla.org/r/152498/#review157890

thanks!

Comment 14

[Robert Wood [:rwood]]

Thanks for the review, try run is good:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=73e5af7f766d51ce69a160363c0d4436776cc3ff

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e2b8234a6b5
Fix running talos quantum_pageload_* tests locally with -activeTests; r=jmaher

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e2b8234a6b5