1375504 - Add some asserts to CacheIR code

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Jan de Mooij [:jandem]]

There are some invariants we could easily assert.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

Just to get this (finally) out of my needinfo queue, here's a patch that asserts:

* Instructions don't allocate registers after we call addFailurePath.
* Instructions don't call addFailurePath more than once.
* Different operands never have aliasing registers or stack slots.

Comment 2

[Ted Campbell [:tcampbell]]

Comment on attachment 8975409 [details] [diff] [review]
Patch

Review of attachment 8975409 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: js/src/jit/CacheIRCompiler.h
@@ +305,5 @@
>      // The number of bytes pushed on the native stack.
>      uint32_t stackPushed_;
>  
> +#ifdef DEBUG
> +    // Flag used to assert instructions don't allocate registers after calling

> .. assert individual CacheIR instructions ..

I was initially unclear on the scope of this check.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8a9fd5984cc
Add some asserts to the CacheIR code. r=tcampbell

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b8a9fd5984cc