Closed Bug 1375513 Opened 2 years ago Closed 2 years ago

stylo: Non-chrome XBL bindings with stylesheets does not work

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(2 files)

When writing a reftest for bug 1372876, I found that non-chrome XBL bindings, which are loaded asynchronously at [1], do not work.

bz gave some hints on how to fix this in bug 1290276 comment 24.

[1] http://searchfox.org/mozilla-central/rev/ae94cfb36d804727dfb38f2750bfcaab4621df6e/dom/xbl/nsXBLResourceLoader.cpp#154
Comment on attachment 8881764 [details]
Bug 1375513 Part 1 - Support non-chrome XBL bindings with stylesheets for stylo.

https://reviewboard.mozilla.org/r/152834/#review158124
Attachment #8881764 - Flags: review?(cam) → review+
Comment on attachment 8881765 [details]
Bug 1375513 Part 2 - Add a reftest for testing non-chrome XBL bindings with stylesheets.

https://reviewboard.mozilla.org/r/152836/#review158126
Attachment #8881765 - Flags: review?(cam) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s fe17d6a2b897 -d c0c5f6c55d3a: rebasing 404414:fe17d6a2b897 "Bug 1375513 Part 1 - Support non-chrome XBL bindings with stylesheets for stylo. r=heycam"
rebasing 404415:2aec210318fa "Bug 1375513 Part 2 - Add a reftest for testing non-chrome XBL bindings with stylesheets. r=heycam" (tip)
merging layout/reftests/bugs/reftest.list
warning: conflicts while merging layout/reftests/bugs/reftest.list! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/110a0f56c068
Part 1 - Support non-chrome XBL bindings with stylesheets for stylo. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d48ab89f898c
Part 2 - Add a reftest for testing non-chrome XBL bindings with stylesheets. r=heycam
https://hg.mozilla.org/mozilla-central/rev/110a0f56c068
https://hg.mozilla.org/mozilla-central/rev/d48ab89f898c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.