Open Bug 1375565 Opened 7 years ago Updated 2 years ago

GC: Do nursery allocation for external strings

Categories

(Core :: JavaScript: GC, enhancement, P2)

Product:
Core
Component:
JavaScript: GC
Version:
53 Branch
Type:
enhancement

Tracking

()

Project Flags:
Performance Impact low

People

(Reporter: bzbarsky, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf) 

Once bug 903519 is done, we should nursery-allocate external strings.

We've checked, and both XPCStringConvert::FinalizeLiteral and XPCStringConvert::FinalizeDOMString are safe to call on arbitrary threads.  If we wanted to, we could also add a boolean member to JSStringFinalizer that indicates whether the finalizer is safe to call on random threads.
Whiteboard: [qf]
Whiteboard: [qf] → [qf:p1]
Priority: -- → P2
This bug will not be addressed for 57. Change from qf:p1 to qf:p2 for post 57 work.
Whiteboard: [qf:p1] → [qf:p2]
Keywords: perf
Changing to qf:p3. There is not a clear understanding of the magnitude of perf benefit, and the underlying blocker (JSStrings in the nursery) is being worked on intermittently and seems more significant and is p1 already.
Whiteboard: [qf:p2] → [qf:p3]
Depends on: 1442481
Blocks: 1507445
Performance Impact: --- → P3
Whiteboard: [qf:p3]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.