1375615 - Grid inspector (on layout panel) goes blank when trying to highlight named areas

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Potch [:potch]]

# STR:

Open the associated URL.
Turn on the grid lines in the layout panel.
Toggle on "Display grid areas"

# Expected:

No effect, as example has named lines but no areas.

# Observed:

All grid lines disappear until "Display grid areas" is toggled off.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1375615 - Don't render the grid areas overlay for implicit named grid areas.

Review commit: https://reviewboard.mozilla.org/r/152404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152404/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1d59345aaa4fc5d444d01b6e09768d8eca51235

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

The current proposed solution is to ignore rendering implicitly named grid areas, so, it won't appear broken. I believe the grid area data we are getting for the implicitly named grid areas are incorrect, and will talk to brad more about it. I haven't considered showing implicitly named grid areas either so we should consider this in a new bug as well.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8881075 [details]
Bug 1375615 - Don't render the grid areas overlay for implicit named grid areas.

https://reviewboard.mozilla.org/r/152404/#review157526

Sounds like a good first fix to me. Please file a the other bug to really deal with implicit grid areas later.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50d9b2bfa802
Don't render the grid areas overlay for implicit named grid areas. r=pbro

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/50d9b2bfa802