Closed Bug 1375678 Opened 2 years ago Closed 2 years ago

Enable eslint on testing/modules

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
These changes were made with |mach eslint --fix| -- nothing fancy.
Attachment #8880590 - Flags: review?(standard8)
I verified the changes to StructuredLog.jsm with :ahal.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=940735eb2240f770292939690f76a5f00e0bf424
Attachment #8880591 - Flags: review?(standard8)
Comment on attachment 8880590 [details] [diff] [review]
stop ignoring testing/modules and apply --fix

Review of attachment 8880590 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/modules/tests/xpcshell/test_mockRegistrar.js
@@ +21,1 @@
>    run_next_test();

This is actually a useless function definition as xpcshell's head.js defines run_test to call run_next_test if run_test isn't present in the test file.

Hence, lets just drop this run_test function from this file as we're here.
Attachment #8880590 - Flags: review?(standard8) → review+
Comment on attachment 8880591 [details] [diff] [review]
additional changes

Review of attachment 8880591 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8
Attachment #8880591 - Flags: review?(standard8) → review+
(In reply to Mark Banner (:standard8) from comment #3)
> Hence, lets just drop this run_test function from this file as we're here.

Sure, will do.
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/edbec3a0e1a7
Enable lint on testing/modules - mechanical changes; r=standard8
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4370aa1b18
Enable eslint on testing/modules - additional changes; r=standard8
https://hg.mozilla.org/mozilla-central/rev/edbec3a0e1a7
https://hg.mozilla.org/mozilla-central/rev/ac4370aa1b18
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.