1375678 - Enable eslint on testing/modules

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Comment 1

[Geoff Brown [:gbrown]]

Attachment: stop ignoring testing/modules and apply --fix

These changes were made with |mach eslint --fix| -- nothing fancy.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: additional changes

I verified the changes to StructuredLog.jsm with :ahal.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=940735eb2240f770292939690f76a5f00e0bf424

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8880590 [details] [diff] [review]
stop ignoring testing/modules and apply --fix

Review of attachment 8880590 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/modules/tests/xpcshell/test_mockRegistrar.js
@@ +21,1 @@
>    run_next_test();

This is actually a useless function definition as xpcshell's head.js defines run_test to call run_next_test if run_test isn't present in the test file.

Hence, lets just drop this run_test function from this file as we're here.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8880591 [details] [diff] [review]
additional changes

Review of attachment 8880591 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8

Comment 5

[Geoff Brown [:gbrown]]

(In reply to Mark Banner (:standard8) from comment #3)
> Hence, lets just drop this run_test function from this file as we're here.

Sure, will do.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/edbec3a0e1a7
Enable lint on testing/modules - mechanical changes; r=standard8
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4370aa1b18
Enable eslint on testing/modules - additional changes; r=standard8

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/edbec3a0e1a7
https://hg.mozilla.org/mozilla-central/rev/ac4370aa1b18