1375689 - Turn on experimentalObjectRestSpread in ESlint options

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P2)

Description

[Tim Nguyen :ntim]

http://eslint.org/docs/user-guide/configuring#specifying-parser-options

Firefox just implemented es object spread (bug 1339395), it would be nice to be able to use it in the source code. Unfortunately, the current eslint config prevents from using object spread. experimentalObjectRestSpread needs to be turned on to use object spread.

Comment 1

[Tim Nguyen :ntim]

What do you think ?

Comment 2

[Mark Banner (:standard8)]

I think this should be fine. Generally in the past I've seen it requested that new js features aren't used for a release or two. However, seeing as that was implemented in 55 that is probably fine now.

Comment 3

[Mark Banner (:standard8)]

We should do this asap after the eslint 4 patches land.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1375689 - Turn on experimentalObjectRestSpread in ESlint options.

Review commit: https://reviewboard.mozilla.org/r/199400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199400/

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8928154 [details]
Bug 1375689 - Turn on experimentalObjectRestSpread in ESlint options.

https://reviewboard.mozilla.org/r/199400/#review204594

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b135d7d8cef
Turn on experimentalObjectRestSpread in ESlint options. r=mossop

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0b135d7d8cef