Closed
Bug 1375744
Opened 8 years ago
Closed 8 years ago
Add U2FTokenTransport::Cancel() to abort requests on HW devices
Categories
(Core :: DOM: Device Interfaces, enhancement)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Whiteboard: [webauthn])
Attachments
(1 file, 3 obsolete files)
|
10.87 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
We currently don't forward WebAuthn::Cancel() to the actual token manager implementation. We need to do this to abort requests to HW devices, i.e. stop polling for USB keys, etc.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8880705 -
Flags: review?(kyle)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Small fix.
Attachment #8880705 -
Attachment is obsolete: true
Attachment #8880705 -
Flags: review?(kyle)
Attachment #8880706 -
Flags: review?(kyle)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Remove unused method.
Attachment #8880706 -
Attachment is obsolete: true
Attachment #8880706 -
Flags: review?(kyle)
Attachment #8880773 -
Flags: review?(kyle)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Back to v2, sorry for the noise. The method was actually used :/
Attachment #8880773 -
Attachment is obsolete: true
Attachment #8880773 -
Flags: review?(kyle)
Attachment #8880781 -
Flags: review?(kyle)
|
||
Updated•8 years ago
|
Attachment #8880781 -
Flags: review?(kyle) → review+
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6910856b1ae9
Add U2FTokenTransport::Cancel() to abort requests on HW devices r=qDot
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•