Closed Bug 1375744 Opened 4 years ago Closed 4 years ago

Add U2FTokenTransport::Cancel() to abort requests on HW devices

Categories

(Core :: DOM: Device Interfaces, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [webauthn])

Attachments

(1 file, 3 obsolete files)

We currently don't forward WebAuthn::Cancel() to the actual token manager implementation. We need to do this to abort requests to HW devices, i.e. stop polling for USB keys, etc.
Small fix.
Attachment #8880705 - Attachment is obsolete: true
Attachment #8880705 - Flags: review?(kyle)
Attachment #8880706 - Flags: review?(kyle)
Remove unused method.
Attachment #8880706 - Attachment is obsolete: true
Attachment #8880706 - Flags: review?(kyle)
Attachment #8880773 - Flags: review?(kyle)
Back to v2, sorry for the noise. The method was actually used :/
Attachment #8880773 - Attachment is obsolete: true
Attachment #8880773 - Flags: review?(kyle)
Attachment #8880781 - Flags: review?(kyle)
Attachment #8880781 - Flags: review?(kyle) → review+
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6910856b1ae9
Add U2FTokenTransport::Cancel() to abort requests on HW devices r=qDot
https://hg.mozilla.org/mozilla-central/rev/6910856b1ae9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1400662
You need to log in before you can comment on or make changes to this bug.