[cross-osx] ERROR: Could not find the clang shared library in the path /home/worker/workspace/build/src/clang/lib

RESOLVED FIXED in Firefox 56

Status

defect
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla56
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(5 attachments)

Assignee

Description

2 years ago
Cross OSX builds end with:

[task 2017-06-23T09:02:55.406134Z] 09:02:55     INFO -  checking for llvm-config... /home/worker/workspace/build/src/clang/bin/llvm-config
[task 2017-06-23T09:02:55.413715Z] 09:02:55     INFO -  ERROR: Could not find the clang shared library in the path /home/worker/workspace/build/src/clang/lib
[task 2017-06-23T09:02:55.413877Z] 09:02:55     INFO -  returned by `llvm-config --libdir` (searched for files [u'libclang.so.1', u'libclang.dylib']).
Assignee

Updated

2 years ago
Blocks: 1368083
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8880760 [details]
Bug 1375798 - Add a unit test for library/object prefix/suffixes.

https://reviewboard.mozilla.org/r/152132/#review157726
Attachment #8880760 - Flags: review?(mshal) → review+

Comment 7

2 years ago
mozreview-review
Comment on attachment 8880761 [details]
Bug 1375798 - Limit the SO_VERSION option to openbsd builds.

https://reviewboard.mozilla.org/r/152134/#review157878
Attachment #8880761 - Flags: review?(mshal) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8880762 [details]
Bug 1375798 - Reorganize the library_name_info function.

https://reviewboard.mozilla.org/r/152136/#review157884

Nice! This is much easier to understand.
Attachment #8880762 - Flags: review?(mshal) → review+

Comment 9

2 years ago
mozreview-review
Comment on attachment 8880763 [details]
Bug 1375798 - Avoid using target_is_windows and target_is_darwin in library_name_info.

https://reviewboard.mozilla.org/r/152138/#review157888
Attachment #8880763 - Flags: review?(mshal) → review+

Comment 10

2 years ago
mozreview-review
Comment on attachment 8880764 [details]
Bug 1375798 - Figure out host library/object prefix/suffixes and use them for libclang.

https://reviewboard.mozilla.org/r/152140/#review157894

::: moz.configure:147
(Diff revision 1)
>  @depends('SO_VERSION', when=is_openbsd)
>  def so_version(value):
>      return value
>  
> -@depends(target, c_compiler, so_version)
> +@template
> +def library_name_info(host_or_target):

It's a bit confusing to have library_name_info() be:

1) a function
2) a nested function within the first function
3) a variable set to the value of the function.

Can we come up with different names for 1) and 2)?

::: moz.configure:155
(Diff revision 1)
> +        host: host_c_compiler,
> +        target: c_compiler,
> +    }[host_or_target]
> +
> +    @depends(host_or_target, compiler, so_version)
> -def library_name_info(target, c_compiler, so_version):
> +    def library_name_info(target, c_compiler, so_version):

Shouldn't this match the @depends variable names? Eg: 'target' here is really either a host or a target, which makes some of the if statements below read slightly inaccurately (even though it works). So I'd suggest (host_or_target, compiler, so_version)
Attachment #8880764 - Flags: review?(mshal) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 16

2 years ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/0f78019d37dc
Add a unit test for library/object prefix/suffixes. r=mshal
https://hg.mozilla.org/integration/autoland/rev/9e83254e336b
Limit the SO_VERSION option to openbsd builds. r=mshal
https://hg.mozilla.org/integration/autoland/rev/374900b2142a
Reorganize the library_name_info function. r=mshal
https://hg.mozilla.org/integration/autoland/rev/8847981eee44
Avoid using target_is_windows and target_is_darwin in library_name_info. r=mshal
https://hg.mozilla.org/integration/autoland/rev/a07449eb1876
Figure out host library/object prefix/suffixes and use them for libclang. r=mshal

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.