Closed
Bug 1375812
Opened 7 years ago
Closed 7 years ago
stylo: Should build an identify matrix for InterpolateMatrix
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: boris, Assigned: boris)
References
Details
Attachments
(3 files, 1 obsolete file)
These is a case we crash because we didn't build an identity matrix for InterpolateMatrix:
<style>
#target {
width: 100px;
height: 100px;
background-color: blue;
transition: all 10s linear;
transform: translateX(100px);
}
</style>
<script>
var div = document.getElementById('target');
div.style.setProperty("transform", "rotate(60deg)", "");
window.getComputedStyle(div).transform;
div.style.setProperty("transform", "none", "");
</script>
<div id="target"></div>
We might trigger an transition from an InterpolateMatrix to none, so panic [1].
[1] http://searchfox.org/mozilla-central/rev/3291398f10dcbe192fb52e74974b172616c018aa/servo/components/style/properties/helpers/animated_properties.mako.rs#1629
|
||
Comment 1•7 years ago
|
||
I think we've been using P1 for stability issues like this.
Priority: P2 → P1
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8881395 [details] Bug 1375812 - Build an identity matrix for InterpolateMatrix. https://reviewboard.mozilla.org/r/152548/#review157850 r=me assuming we also have a test that shows this gives the correct result
Attachment #8881395 -
Flags: review?(bbirtles) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8881396 [details] Bug 1375812 - Add crashtest for interpolation between interpolatematrix and none. https://reviewboard.mozilla.org/r/152550/#review157852
Attachment #8881396 -
Flags: review?(bbirtles) → review+
| Comment hidden (mozreview-request) |
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8881846 [details] Bug 1375812 - Test the result of interpolation from interpolatematrix to none. https://reviewboard.mozilla.org/r/152916/#review158128
Attachment #8881846 -
Flags: review?(bbirtles) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8881395 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•7 years ago
|
||
|
||
Comment 12•7 years ago
|
||
Pushed by bchiou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb9ac25d6756 Add crashtest for interpolation between interpolatematrix and none. r=birtles https://hg.mozilla.org/integration/autoland/rev/5394e6b2347b Test the result of interpolation from interpolatematrix to none. r=birtles
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bb9ac25d6756 https://hg.mozilla.org/mozilla-central/rev/5394e6b2347b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•