omnibox API: allow calling the suggestion callback from onInputChanged multiple times

UNCONFIRMED
Unassigned

Status

()

Toolkit
WebExtensions: Frontend
P5
enhancement
UNCONFIRMED
4 months ago
a month ago

People

(Reporter: bucklereed, Unassigned)

Tracking

({feature})

52 Branch
feature
Points:
---

Firefox Tracking Flags

(firefox57 wontfix)

Details

(Whiteboard: [design-decision-needed])

Attachments

(2 attachments)

374 bytes, application/javascript
Details
174 bytes, application/json
Details
(Reporter)

Description

4 months ago
Created attachment 8880818 [details]
background.js

User Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170613225334

Steps to reproduce:

Install the attached WebExtension. Type 'example foo' in the location bar.


Actual results:

The suggestion is 'First' and stays that way. This is Chromium's behaviour as well.


Expected results:

The suggestion would be 'Second'.

WebExtensions might be able to offer some suggestions quickly, while also wanting to retrieve more or better suggestions asynchronously (e.g., if they hit the network or perform heavier computation). But, presently, calling the addSuggestions callback uses it up.

This behaviour would not be inconsistent with the rest of the awesomebar machinery, where different suggestions can pop up after different amounts of delay. I'm not sure if this might introduce problems with, say, the user moving between the selections and then a new batch arrive; how does the awesomebar deal with this sort of thing?
(Reporter)

Comment 1

4 months ago
Created attachment 8880819 [details]
manifest.json

Updated

4 months ago
Component: Untriaged → WebExtensions: Frontend
Product: Firefox → Toolkit

Updated

a month ago
Severity: normal → enhancement
status-firefox57: --- → wontfix
Keywords: feature
Priority: -- → P5
Whiteboard: [design-decision-needed]
You need to log in before you can comment on or make changes to this bug.