137589 - Tinderbox is stuck waiting for input from CGI.pm in process/verify-new-product.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[David D. Kilzer (ddk)]

After Bug 125660 (Templatise process_bug.cgi) was checked in,
the t/004template.t template test gets stuck on the following
line from the template/default/process/verify-new-product.html.tmpl
template:

[% USE mycgi = CGI %]

It is similar to what happens when this is run from the
command-line (hit Ctrl-C or Ctrl-D on *NIX to exit):

perl -e 'use CGI; my $query = new CGI;'

There are two fixes for this:

1. Add a line like this to t/004template.t:

use CGI qw(-no_debug);

   Because CGI.pm would already be included in the test script,
   including it again in the template has no effect, and the
   '-no_debug' switch turns off this feature for testing.

2. Change template/default/process/verify-new-product.html to
   include the '-no_debug' switch:

[% USE mycgi = CGI('-no_debug') %]

Any preference as to the fix?

Comment 1

[David D. Kilzer (ddk)]

Attachment: Patch Alt #1 (t/004template.t)

Adds a 'use CGI qw(-no_debug);' line to t/004template.t to
avoid hanging when testing process/verify-new-product.html.tmpl.

Comment 2

[David D. Kilzer (ddk)]

Attachment: Patch Alt #2 (process/verify-new-product.html.tmpl)

Changes USE directive in process/verify-new-product.html.tmpl
to avoid hanging during testing.

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 79299 [details] [diff] [review]
Patch Alt #1 (t/004template.t)

The script works fine. So we should fix the test, not the script.

Gerv

Comment 4

[David D. Kilzer (ddk)]

Comment on attachment 79300 [details] [diff] [review]
Patch Alt #2 (process/verify-new-product.html.tmpl)

Marking obsolete per Comment #3.

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 79299 [details] [diff] [review]
Patch Alt #1 (t/004template.t)

Waht version of perl/CGI/pm are you using?

I don't need this patch - is this another version difference thing?

r=bbaetz, since it can't hurt, although I fail tests ATM because of missing
version strings in show/navigate

Comment 6

[Gervase Markham [:gerv]]

Fixed. (Not wanting to step on ddk's toes, but it is a trivial checkin.) Let's
see if this get the tbox working again.

Checking in t/004template.t;
/cvsroot/mozilla/webtools/bugzilla/t/004template.t,v  <--  004template.t
new revision: 1.11; previous revision: 1.10
done

(Oops; forgot credits in checkin comment. Doh. Never mind.)

Gerv

Comment 7

[David D. Kilzer (ddk)]

bbaetz: I'm using CGI.pm v2.56 that was causing 'make test' to
get stuck on my system.

Comment 8

[David D. Kilzer (ddk)]

See also Bug 141003.