1375956 - Disable the browser UI in more Talos tests that shouldn't be exercising it.

Status: RESOLVED FIXED

(Testing :: Talos, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Similar to bug 1374765, there are more Talos tests where it doesn't make sense to capture behaviour in the browser UI within the context of the tests.

Those tests are:

1. tsvgr_opacity
2. glterrain
3. dromaeo (dom and css)
4. tscrollx
5. basic_compositor_video
6. glvideo
7. a11yr

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1375956 - Disable browser UI for more Talos tests that should not care about changes in the browser UI.

Review commit: https://reviewboard.mozilla.org/r/152276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152276/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Just a heads up igoldan - this just changes the conditions of the test. Any Talos regressions or improvements from this landing should be ignored.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8880910 [details]
Bug 1375956 - Disable browser UI for more Talos tests that should not care about changes in the browser UI.

https://reviewboard.mozilla.org/r/152276/#review157330

this was an easy review, please ensure talos runs fine |mach try -b o -p win32,win64,macosx64,linux64 -u none -t all --rebuild 3| works fine

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67dca71a25c4
Disable browser UI for more Talos tests that should not care about changes in the browser UI. r=jmaher

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

this got landed in the lucky window of a broken build:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=84467f2e7e673ba1ba9995766c4a632f80e10492&tochange=a900b7e7572b52618dd36b645daae1767139cf82

but given the failures and the few patches, it looks like we see a couple regressions:
== Change summary for alert #7520 (as of June 23 2017 22:49 UTC) ==

Regressions:

 15%  tscrollx summary osx-10-10 opt e10s     3.33 -> 3.81
  4%  basic_compositor_video summary linux64 pgo e10s3.69 -> 3.84

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7520


There has been almost no data since this landed, so I would expect other change to show up and we will associate them with that alert.

Please comment if the numbers seem unexpected.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/67dca71a25c4

Comment 7

[Mike Conley (:mconley) (:⚙️)]

These regressions are certainly due to the fact that we increased the size of the content area, and can be ignored.