Closed
Bug 1375988
Opened 7 years ago
Closed 7 years ago
Empty notification received on Firefox Beta
Categories
(Firefox for iOS :: Firefox Accounts, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | 10.0 | --- |
People
(Reporter: st3fan, Unassigned)
References
Details
(Whiteboard: [MobileCore][AutoPush][8.2])
Attachments
(1 file)
The very first notification I received was empty. No title, no contents. Screenshot attached. It is unclear if this was a fxaccount:* notification or if this was the result of me sending myself a tab from Desktop.
Reporter | ||
Comment 1•7 years ago
|
||
Firefox Beta 4218 via Internal TestFlight
Reporter | ||
Updated•7 years ago
|
Severity: normal → blocker
Reporter | ||
Updated•7 years ago
|
tracking-fxios:
--- → 8.0+
Comment 2•7 years ago
|
||
Quick drive-by, but...IIRC FxA will send a push notification with no payload when you verify your account or confirm a signin, might be a good candidate to look at for debugging this.
Reporter | ||
Comment 3•7 years ago
|
||
Why no payload? Is there no way to identify this notification? Are you saying we can we assume that a zero length message is the sign in confirmation? We cannot ignore this message, and I don't think we have a good string for it. Should this be the "Tap to begin" notification maybe?
Flags: needinfo?(rfkelly)
Comment 4•7 years ago
|
||
> Are you saying we can we assume that a zero length message is the sign in confirmation?
Yes. For historical reasons (we added this one before payloads were properly supported end-to-end) the "you are now verified" event is signaled by a push notification with empty body. It will mean either "your email address was successfully verified" or "your login session was successfully confirmed", depending on whether you did a signup or a signin. But in either case what it means is basically "you're now ready to start syncing".
I expect we could disable this message on the server though, in the same way we intend to disable the other unsupported messages.
Flags: needinfo?(rfkelly)
Comment 5•7 years ago
|
||
On desktop, this event surfaces as a "sync will begin momentarily" notification.
Reporter | ||
Comment 6•7 years ago
|
||
I think it is a good idea to disable this one on the server for now. We can address it when we have strings for this notification. Is it possible to give this notification a proper payload so that we can see the difference between signup or signin? Cc to :vladikoff to request a Github issue for this
Flags: needinfo?(vlad)
Reporter | ||
Comment 7•7 years ago
|
||
Moving this to 8.1
Comment 8•7 years ago
|
||
(In reply to Stefan Arentz [:st3fan] from comment #7) > Moving this to 8.1 Can we remove `Importance: P1 blocker` from this? (If this was moved for later release) > Is it possible to give this notification a proper payload so that we can see the difference between signup or signin? We can try! I filed an issue here: https://github.com/mozilla/fxa-auth-server/issues/1976
Flags: needinfo?(vlad)
Reporter | ||
Updated•7 years ago
|
Severity: blocker → normal
Priority: P1 → --
Comment 9•7 years ago
|
||
I receiving an empty notification intermittently when following this steps: 1. Same FxA signed in on: - Nightly 56.0a1 (2017-07-09) - iPad Mini (10.3.1) - iPhone 6 Plus (10.3.2) 2. Send a few tabs from desktop to iPad 3. Send a few tabs from desktop to iPhone 4. Select a tab on desktop and "Send to All Devices" Result: Once in a while, when sending to all devices, I'm getting an extra empty push notification on iPad. This doesn't seem to happen on iPhone.
Reporter | ||
Comment 10•7 years ago
|
||
The above is with Beta 4467
Comment 11•7 years ago
|
||
Taking this to investigate.
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Reporter | ||
Updated•7 years ago
|
Whiteboard: [MobileCore][AutoPush] → [MobileCore][AutoPush][8.2]
Reporter | ||
Comment 13•7 years ago
|
||
Moving this to 9.0. Also, this bug needs to turn into one that is more concrete/actionable.
Updated•7 years ago
|
Assignee: jdarcangelo → nobody
Status: ASSIGNED → NEW
Updated•7 years ago
|
Comment 14•7 years ago
|
||
Attachment #8917449 -
Flags: review?(vbudhram)
Comment 16•7 years ago
|
||
Comment on attachment 8917449 [details] [review] Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3279 LGTM
Attachment #8917449 -
Flags: review?(vbudhram) → review+
Comment 17•7 years ago
|
||
Merged into master. Uplifted to v10.x 64680b2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•