1376135 - Update Debugger frontend (6/24/2017)

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Comment 1

[Jason Laster [:jlast]]

Attachment: 6-24-1.patch

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cb70ef8073a0ed04635d364d11e11b1066138f6

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8881073 [details] [diff] [review]
6-24-1.patch

Review of attachment 8881073 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! Sorry for the super late review.

Two things:
- one typo to address (see comment). Weird that it didn't fail any test on try though.
- did you intentionally get rid of the fade-out effect for out of scope code?

::: devtools/client/debugger/new/test/mochitest/head.js
@@ +584,5 @@
>  const isMac = Services.appinfo.OS === "Darwin";
>  const cmdOrCtrl = isLinux ? { ctrlKey: true } : { metaKey: true };
> +const shiftOrAlt = isMac
> +  ? { accelKey: true, shiftKey: true }
> +  : { aaccelKey: true, ltKey: true };

This looks like a typo ?

`aaccelKey: true, ltKey: true` => `accelKey: true, altKey: true`

Comment 4

[Jason Laster [:jlast]]

Oops, that's definitely a typo. 
Yea, I intentionally dropped the fade out affect. It was slow and I don't think the UX was right at 85%.

Comment 5

[Jason Laster [:jlast]]

Attachment: 6-24-2.patch

Comment 6

[Jason Laster [:jlast]]

Attachment: 6-24-3.patch

Comment 7

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f39a817829f27f24e6dcafeb71482bb8f3c6753a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd35803f53f8
Upgrade debugger frontend v0.7.0 (6/24). r=jdescottes

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bd35803f53f8