137623 - showdependencytree.cgi has minor grammatical and formatting issues

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The following two complete sentences appear without periods:

  This bug appears elsewhere in this tree.
  Only bugs whose depth is less than # will be shown.

The following sentence is redundantly highlighted (italic style and angle brackets):

  This bug appears elsewhere in this tree.

The following sentence is redundantly highlighted (bold style and parentheses):

  Only bugs whose depth is less than # will be shown.

The following tree meta-data are inside the tree title:

  Only bugs whose depth is less than # will be shown.
  view as bug list
  change several

The depth sentence is misleading and unnecessarily complicated.  It should be:

  (up to # levels deep)

Words in the tree titles are not capitalized.

The word "bug" in the expression "bug ####" is not linked.

The "unlimited" link is enabled even when an unlimited number of levels are
already being displayed.

The number of levels is displayed even when it is greater than the maximum depth
of the tree.

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Try this on for size.

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

Comment on attachment 80853 [details] [diff] [review]
Patch v.1 


>+  [% IF maxdepth -%]Up to [% maxdepth %] levels deep | [% END %]

s/levels/level[% "s" IF maxdepth > 1 %]/

and the same thing below (why do we have duplicate code, btw?)

r=bbaetz with that fix

Comment 3

[Gervase Markham [:gerv]]

We have duplicate code, I think, because Myk decided it would be too complex
parameterised. I agree with him.

Gerv

Comment 4

[Gervase Markham [:gerv]]

Attachment: Patch v.2

With bbaetz' requested markup.

Gerv

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 81183 [details] [diff] [review]
Patch v.2

r= justdave

Comment 6

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v
 <--  dependency-tree.html.tmpl
new revision: 1.4; previous revision: 1.3
done

Gerv