1376300 - Missing getter methods in JDAPFilter classes

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP Java SDK, defect)

Description

[Endi S. Dewata]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170608105825

Steps to reproduce:

The LDAP Java SDK provides a mechanism to parse a string LDAP filter into a JDAPFilter object tree:

  JDAPFilter filter = JDAPFilter.getFilter(strFilter);

However, some of the JDAPFilter classes do not provide methods to access the fields in the objects, limiting its usability. For example:

 * JDAPFilterSet does not provide getSet() method to access the filter set joined by the AND/OR operators.
* JDAPFilterNot does not provide getFilter() to access the filter negated by NOT operator.
 * JDAPFilterSubString does not provide getInitial(), getAny(), getFinal() to access parts of the substring filter.

Comment 1

[Endi S. Dewata]

Attachment: bug-1376300.patch

Comment 2

[Rich Megginson]

Comment on attachment 8914533 [details] [diff] [review]
bug-1376300.patch

pushed

https://hg.mozilla.org/projects/ldap-sdks/rev/460afcc31771176e7a40f452be14ce5869831ddd

If this looks correct, please close.

Comment 3

[Endi S. Dewata]

That looks correct. Thanks, Rich!

Could someone close this ticket? I don't think I have the permission to do that properly. Thanks!

Comment 4

[Endi S. Dewata]

Fedora ticket: https://bugzilla.redhat.com/show_bug.cgi?id=1465102