1376454 - Remove git submodule to pontoon-intro from the pontoon repository

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P3)

Description

[[DEACTIVATED] Adrian Gaudebert]

Currently pontoon uses a git submodule to load the code for the intro page into the repository. Submodules are generally hard to use and a bad practice, so we should replace with something else.

Plan is as follows:

1. move pontoon-intro code and history into the pontoon repo, _except_ for the content of the ``static/locales``;
2. move the content of ``static/locales`` to the root of the pontoon-intro repo, and remove everything else.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

How about we instead move the content and history of ``static/locales`` into a new repository? That way we have an easier fallback (the current pontoon-intro repo), and we can run some tests.

Comment 2

[Matjaz Horvat [:mathjazz]]

(In reply to Adrian Gaudebert [:adrian] from comment #1)
> How about we instead move the content and history of ``static/locales`` into
> a new repository? That way we have an easier fallback (the current
> pontoon-intro repo), and we can run some tests.

SGTM.

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Here's step one: I have moved the entire ``static/locales`` folder and its history into a new repo, https://github.com/adngdb/pontoon-intro-locales

The next step would be to take the code, without the locales, of pontoon-intro and move it into the pontoon repo. We don't care about the git history there. Now the question is: how do we import the locales into the pontoon website? We don't want to replace the submodule with another one, so I think we'll want to add a step to our build process to pull in the new pontoon-intro-locales content. 

Matjaz, what do you think about that? How easy would that be with the current system?

Comment 4

[Matjaz Horvat [:mathjazz]]

(In reply to Adrian Gaudebert [:adrian] from comment #3)
> Here's step one: I have moved the entire ``static/locales`` folder and its
> history into a new repo, https://github.com/adngdb/pontoon-intro-locales

LGTM. You should move it under the mozilla org.

> The next step would be to take the code, without the locales, of
> pontoon-intro and move it into the pontoon repo. We don't care about the git
> history there. Now the question is: how do we import the locales into the
> pontoon website? We don't want to replace the submodule with another one, so
> I think we'll want to add a step to our build process to pull in the new
> pontoon-intro-locales content. 
> 
> Matjaz, what do you think about that? How easy would that be with the
> current system?

We don't need to import locales into the website. We only need the website to appear on https://pontoon.mozilla.org/intro/ (in English). It's not really localized, it only serves as the source website Pontoon homepage uses for in-context l10n demo.

We should however add a data migration that will point the pontoon-intro project to the new repository by updating the url, permalink_prefix and website fields.

Comment 5

[Matjaz Horvat [:mathjazz]]

(In reply to Matjaz Horvat [:mathjazz] from comment #4)

> We should however add a data migration that will point the pontoon-intro
> project to the new repository by updating the url, permalink_prefix and
> website fields.

And now that projects can use DB as the string source, we can also stop using the string repository.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1064

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/6a1ec623d1518867e6b9b1d2059da00716a03ac0
Fix bug 1376454: Un-submodule pontoon.intro (#1064)

And also:
* Update Pontoon Intro copy to become in-context demo page.
* Rename `intro` app to `in-context` and move URL config into it.
* Remove submodule instructions from developer & deployment docs,
  and travis config.